[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350579#comment-16350579 ] ASF subversion and git services commented on ARTEMIS-1655: -- Commit 9acdec2468aa89cf6dfd99323f87c5c1a351bd0d in activemq-artemis's branch refs/heads/master from [~michael.andre.pearce] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9acdec2 ] ARTEMIS-1655 Fix TransportConfiguration encode failing Check for null on isMaskPassword, seems this regressed in bb84f679363f62e8b2663f63bf23f04133de481d change for ARTEMIS-1600 > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350581#comment-16350581 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1841 > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350268#comment-16350268 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1841 @franz1981 this replaces the previous PR, actually fixing the source of the issue. > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350267#comment-16350267 ] ASF GitHub Bot commented on ARTEMIS-1655: - GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1841 ARTEMIS-1655 Fix TransportConfiguration encode failing Check for null on isMaskPassword, seems this regressed in bb84f679363f62e8b2663f63bf23f04133de481d change for ARTEMIS-1600 You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1841.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1841 commit 9acdec2468aa89cf6dfd99323f87c5c1a351bd0d Author: Michael André PearceDate: 2018-02-02T09:52:38Z ARTEMIS-1655 Fix TransportConfiguration encode failing Check for null on isMaskPassword, seems this regressed in bb84f679363f62e8b2663f63bf23f04133de481d change for ARTEMIS-1600 > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350152#comment-16350152 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1839 @franz1981 if you want to have the honor I’m more than happy letting you merge :) > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350133#comment-16350133 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1839 @michaelandrepearce If it ok I will going to merge it or you do it by yourself? > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350181#comment-16350181 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1839 @franz1981 can you just wait actually, ive jsut seen something, i want to recheck. > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350185#comment-16350185 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1839 > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350179#comment-16350179 ] ASF GitHub Bot commented on ARTEMIS-1655: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1839 @michaelandrepearce As soon as the checks will pass (if jenkins behave normally!!) I will merge it :+1: > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1655) During failover a null key in TransportConfiguration is causing error during encode.
[ https://issues.apache.org/jira/browse/ARTEMIS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350101#comment-16350101 ] ASF GitHub Bot commented on ARTEMIS-1655: - GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1839 ARTEMIS-1655 TransportConfiguration - only encode non-null values Check for null, to avoid encoding issue, this is seen on failover. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1839.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1839 commit 457e96b039a611e87bd8a4e7eb605525e0a815f0 Author: Michael André PearceDate: 2018-02-02T09:52:38Z ARTEMIS-1655 TransportConfiguration - only encode non-null values Check for null, to avoid encoding issue, this is seen on failover. > During failover a null key in TransportConfiguration is causing error during > encode. > > > Key: ARTEMIS-1655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1655 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > > 09:34:37,659 WARN [org.apache.activemq.artemis.utils.actors.OrderedExecutor] > AMQ119033: Invalid type: n > ull: java.lang.IllegalArgumentException: AMQ119033: Invalid type: null > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encodeMap(TransportConfiguration. > java:317) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.api.core.TransportConfiguration.encode(TransportConfiguration.jav > a:336) [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 2.encodeRest(ClusterTopologyChangeMessage_V2.java:88) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAP > SHOT] > at > org.apache.activemq.artemis.core.protocol.core.impl.wireformat.ClusterTopologyChangeMessage_V > 3.encodeRest(ClusterTopologyChangeMessage_V3.java:60) > [artemis-core-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] -- This message was sent by Atlassian JIRA (v7.6.3#76005)