[jira] [Commented] (ARTEMIS-1657) Memory usage on DLQ does not decrement when messages are moved

2018-02-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350586#comment-16350586
 ] 

ASF subversion and git services commented on ARTEMIS-1657:
--

Commit 586487155ca90aca1f42464eaedff7b0ae9a3a5b in activemq-artemis's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5864871 ]

ARTEMIS-1657 - Properly decrement memory usage when moving messages from
queue

When messages are retried and moved froma DLQ to the original queue the
memory usage tracker needs to be decremented


> Memory usage on DLQ does not decrement when messages are moved
> --
>
> Key: ARTEMIS-1657
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1657
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.5.0
>
>
> While doing some testing I noticed that if messages that are sent to the DLQ 
> are retried and moved back to their original queue the memory usage tracker 
> on the DLQ does not get decremented as it should.  This is because the 
> refRemoved() method is never called after moving the message is it should.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1657) Memory usage on DLQ does not decrement when messages are moved

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350588#comment-16350588
 ] 

ASF GitHub Bot commented on ARTEMIS-1657:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1840


> Memory usage on DLQ does not decrement when messages are moved
> --
>
> Key: ARTEMIS-1657
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1657
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.5.0
>
>
> While doing some testing I noticed that if messages that are sent to the DLQ 
> are retried and moved back to their original queue the memory usage tracker 
> on the DLQ does not get decremented as it should.  This is because the 
> refRemoved() method is never called after moving the message is it should.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1657) Memory usage on DLQ does not decrement when messages are moved

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350408#comment-16350408
 ] 

ASF GitHub Bot commented on ARTEMIS-1657:
-

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/1840
  
Updated PR as I found a second spot where the ref counter needed to be 
decremented


> Memory usage on DLQ does not decrement when messages are moved
> --
>
> Key: ARTEMIS-1657
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1657
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.5.0
>
>
> While doing some testing I noticed that if messages that are sent to the DLQ 
> are retried and moved back to their original queue the memory usage tracker 
> on the DLQ does not get decremented as it should.  This is because the 
> refRemoved() method is never called after moving the message is it should.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1657) Memory usage on DLQ does not decrement when messages are moved

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350244#comment-16350244
 ] 

ASF GitHub Bot commented on ARTEMIS-1657:
-

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/1840

ARTEMIS-1657 - Properly decrement memory usage when moving messages


When messages are retried and moved froma DLQ to the original queue the
memory usage tracker needs to be decremented

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1657

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1840.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1840


commit 6ddccf581a9eac692dac68c418d4ce054c83cc93
Author: Christopher L. Shannon (cshannon) 
Date:   2018-02-02T12:39:50Z

ARTEMIS-1657 - Properly decrement memory usage when moving messages from
queue

When messages are retried and moved froma DLQ to the original queue the
memory usage tracker needs to be decremented




> Memory usage on DLQ does not decrement when messages are moved
> --
>
> Key: ARTEMIS-1657
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1657
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.5.0
>
>
> While doing some testing I noticed that if messages that are sent to the DLQ 
> are retried and moved back to their original queue the memory usage tracker 
> on the DLQ does not get decremented as it should.  This is because the 
> refRemoved() method is never called after moving the message is it should.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)