[jira] [Commented] (AMBARI-17181) Add some of value-attributes to property files in AMBARI_METRICS
[ https://issues.apache.org/jira/browse/AMBARI-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357943#comment-15357943 ] Hudson commented on AMBARI-17181: - SUCCESS: Integrated in Ambari-trunk-Commit #5195 (See [https://builds.apache.org/job/Ambari-trunk-Commit/5195/]) AMBARI-17181 : Add some of value-attributes to property files in (avijayan: [http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=7cb58ff2b18a628c2b4f5f24bdc558f3b5f60a20]) * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml * ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml > Add some of value-attributes to property files in AMBARI_METRICS > > > Key: AMBARI-17181 > URL: https://issues.apache.org/jira/browse/AMBARI-17181 > Project: Ambari > Issue Type: Improvement > Components: ambari-metrics, ambari-server >Affects Versions: 2.4.0 >Reporter: Masahiro Tanaka >Assignee: Masahiro Tanaka >Priority: Minor > Fix For: 2.5.0 > > Attachments: AMBARI-17181.1.patch, AMBARI-17181.patch, > after_screenshot.PNG, before_screenshot.PNG > > > Some of the property files in AMBARI_METRICS lack value-attributes. > It would be nice to have value-attributes on most of the properties. If so, > we can notice a careless mistakes in Ambari Server WebUI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-17181) Add some of value-attributes to property files in AMBARI_METRICS
[ https://issues.apache.org/jira/browse/AMBARI-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357684#comment-15357684 ] Masahiro Tanaka commented on AMBARI-17181: -- Thank you [~avijayan]! > Add some of value-attributes to property files in AMBARI_METRICS > > > Key: AMBARI-17181 > URL: https://issues.apache.org/jira/browse/AMBARI-17181 > Project: Ambari > Issue Type: Improvement > Components: ambari-metrics, ambari-server >Affects Versions: 2.4.0 >Reporter: Masahiro Tanaka >Assignee: Masahiro Tanaka >Priority: Minor > Fix For: 2.5.0 > > Attachments: AMBARI-17181.1.patch, AMBARI-17181.patch, > after_screenshot.PNG, before_screenshot.PNG > > > Some of the property files in AMBARI_METRICS lack value-attributes. > It would be nice to have value-attributes on most of the properties. If so, > we can notice a careless mistakes in Ambari Server WebUI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-17181) Add some of value-attributes to property files in AMBARI_METRICS
[
https://issues.apache.org/jira/browse/AMBARI-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334526#comment-15334526
]
Hadoop QA commented on AMBARI-17181:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12810982/after_screenshot.PNG
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7383//console
This message is automatically generated.
> Add some of value-attributes to property files in AMBARI_METRICS
>
>
> Key: AMBARI-17181
> URL: https://issues.apache.org/jira/browse/AMBARI-17181
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-metrics, ambari-server
>Reporter: Masahiro Tanaka
>Assignee: Masahiro Tanaka
>Priority: Minor
> Attachments: AMBARI-17181.1.patch, AMBARI-17181.patch,
> after_screenshot.PNG, before_screenshot.PNG
>
>
> Some of the property files in AMBARI_METRICS lack value-attributes.
> It would be nice to have value-attributes on most of the properties. If so,
> we can notice a careless mistakes in Ambari Server WebUI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-17181) Add some of value-attributes to property files in AMBARI_METRICS
[
https://issues.apache.org/jira/browse/AMBARI-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333011#comment-15333011
]
Hadoop QA commented on AMBARI-17181:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12810972/AMBARI-17181.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7368//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7368//console
This message is automatically generated.
> Add some of value-attributes to property files in AMBARI_METRICS
>
>
> Key: AMBARI-17181
> URL: https://issues.apache.org/jira/browse/AMBARI-17181
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-metrics, ambari-server
>Reporter: Masahiro Tanaka
>Assignee: Masahiro Tanaka
>Priority: Minor
> Attachments: AMBARI-17181.1.patch, AMBARI-17181.patch,
> after_screenshot.PNG, before_screenshot.PNG
>
>
> Some of the property files in AMBARI_METRICS lack value-attributes.
> It would be nice to have value-attributes on most of the properties. If so,
> we can notice a careless mistakes in Ambari Server WebUI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-17181) Add some of value-attributes to property files in AMBARI_METRICS
[
https://issues.apache.org/jira/browse/AMBARI-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326448#comment-15326448
]
Hadoop QA commented on AMBARI-17181:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12809676/AMBARI-17181.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7309//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7309//console
This message is automatically generated.
> Add some of value-attributes to property files in AMBARI_METRICS
>
>
> Key: AMBARI-17181
> URL: https://issues.apache.org/jira/browse/AMBARI-17181
> Project: Ambari
> Issue Type: Bug
> Components: ambari-metrics, ambari-server
>Reporter: Masahiro Tanaka
>Priority: Minor
> Attachments: AMBARI-17181.patch
>
>
> Some of the property files in AMBARI_METRICS lack value-attributes.
> It would be nice to have value-attributes on most of the properties. If so,
> we can notice a careless mistakes in Ambari Server WebUI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-17181) Add some of value-attributes to property files in AMBARI_METRICS
[ https://issues.apache.org/jira/browse/AMBARI-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326220#comment-15326220 ] Masahiro Tanaka commented on AMBARI-17181: -- submit a patch > Add some of value-attributes to property files in AMBARI_METRICS > > > Key: AMBARI-17181 > URL: https://issues.apache.org/jira/browse/AMBARI-17181 > Project: Ambari > Issue Type: Bug > Components: ambari-metrics, ambari-server >Reporter: Masahiro Tanaka >Priority: Minor > Attachments: AMBARI-17181.patch > > > Some of the property files in AMBARI_METRICS lack value-attributes. > It would be nice to have value-attributes on most of the properties. If so, > we can notice a careless mistakes in Ambari Server WebUI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
