[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #10: Implement bitmap setters, getters, and element-wise builder

2022-08-05 Thread GitBox
lidavidm commented on code in PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939046140 ## src/nanoarrow/buffer_inline.h: ## @@ -15,14 +15,20 @@ // specific language governing permissions and limitations // under the License. +#ifndef

[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #10: Implement bitmap setters, getters, and element-wise builder

2022-08-05 Thread GitBox
lidavidm commented on code in PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939027329 ## src/nanoarrow/bitmap_inline.h: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #10: Implement bitmap setters, getters, and element-wise builder

2022-08-03 Thread GitBox
lidavidm commented on code in PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r937046260 ## src/nanoarrow/typedefs_inline.h: ## @@ -0,0 +1,172 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.