[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942470780 ## src/nanoarrow/nanoarrow.h: ## @@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array, struct ArrowBitmap* b ArrowErrorCode

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942446356 ## src/nanoarrow/array_inline.h: ## @@ -0,0 +1,146 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942442675 ## src/nanoarrow/nanoarrow.h: ## @@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array, struct ArrowBitmap* b ArrowErrorCode

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942441450 ## src/nanoarrow/nanoarrow.h: ## @@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array, struct ArrowBitmap* b ArrowErrorCode

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942437669 ## src/nanoarrow/nanoarrow.h: ## @@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array, struct ArrowBitmap* b ArrowErrorCode

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942434862 ## src/nanoarrow/utils_inline.h: ## @@ -26,6 +26,114 @@ extern "C" { #endif +static inline void ArrowLayoutInit(struct ArrowLayout* layout, +

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #16: Implement array appenders

2022-08-10 Thread GitBox
paleolimbot commented on code in PR #16: URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942431188 ## src/nanoarrow/typedefs_inline.h: ## @@ -166,6 +166,24 @@ enum ArrowType { NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO }; +/// \brief Functional types of