[
https://issues.apache.org/jira/browse/ARROW-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448292#comment-16448292
]
ASF GitHub Bot commented on ARROW-2497:
---------------------------------------
joshuastorck commented on issue #458: ARROW-2497: [C++] Adding use of
ASSERT_NO_FATAL_FAILURE in unit tests when calling helper functions that call
ASSERT_ macros
URL: https://github.com/apache/parquet-cpp/pull/458#issuecomment-383612464
Created a JIRA and updated this PR's title to associate it as a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ASSERT_NO_FATAIL_FAILURE in C++ unit tests
> ----------------------------------------------
>
> Key: ARROW-2497
> URL: https://issues.apache.org/jira/browse/ARROW-2497
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Joshua Storck
> Priority: Minor
> Labels: pull-request-available
>
> A number of unit tests have helper functions that use gtest/arrow ASSERT_
> macros. Those ASSERT_ macros simply return out of the current context and do
> not throw exceptions or abort. Since these helper functions return void, the
> unit test simply continues when the assertions are triggered. This can lead
> to additional failures, such as segfaults because the test is executing code
> that it did not expect to. By adding the gtest ASSERT_NO_FATAIL_FAILURE to
> the calls of those helper functions in the outermost scope of the unit test,
> the test will correctly terminate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
