[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-07-16 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886188#comment-16886188 ] Antoine Pitrou commented on ARROW-4648: --- One thing of note is that we install utilities such as

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824108#comment-16824108 ] Wes McKinney commented on ARROW-4648: - Regarding file formats * src/parquet mostly defines a

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824107#comment-16824107 ] Wes McKinney commented on ARROW-4648: - TensorFlow is using underscores for everything including

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-23 Thread Krisztian Szucs (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823935#comment-16823935 ] Krisztian Szucs commented on ARROW-4648: Agree with Antoine, I'd prefer hyphens. >

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-23 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823835#comment-16823835 ] Antoine Pitrou commented on ARROW-4648: --- I would strongly prefer we don't mix underscores and

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-22 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823160#comment-16823160 ] Wes McKinney commented on ARROW-4648: - Yes, I would be in favor of underscores (with the exception of

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-18 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821336#comment-16821336 ] Micah Kornfield commented on ARROW-4648: I prefer "_" for file names (which the style guide

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-04-17 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820231#comment-16820231 ] Antoine Pitrou commented on ARROW-4648: --- I would welcome fixing filenames (standardize on either

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-03-01 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782074#comment-16782074 ] Francois Saint-Jacques commented on ARROW-4648: --- There's also the issue that we don't

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-02-21 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774507#comment-16774507 ] Wes McKinney commented on ARROW-4648: - I think once we start the "C++ Dataset" project (design doc I

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-02-21 Thread Krisztian Szucs (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774118#comment-16774118 ] Krisztian Szucs commented on ARROW-4648: `cuda/cuda_` and `array/builder_` prefixes are also

[jira] [Commented] (ARROW-4648) [C++/Question] Naming/organizational inconsistencies in cpp codebase

2019-02-21 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774089#comment-16774089 ] Francois Saint-Jacques commented on ARROW-4648: --- There's also an inconsistent usage of `_`