[
https://issues.apache.org/jira/browse/ARROW-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782203#comment-16782203
]
Paul Taylor commented on ARROW-4728:
------------------------------------
Thanks [~fsaintjacques], I submitted https://github.com/apache/arrow/pull/3789
with a fix
> [JS] Failing test Table#assign with a zero-length Null column round-trips
> through serialization
> -----------------------------------------------------------------------------------------------
>
> Key: ARROW-4728
> URL: https://issues.apache.org/jira/browse/ARROW-4728
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: 0.12.1
> Reporter: Francois Saint-Jacques
> Assignee: Paul Taylor
> Priority: Major
> Labels: ci-failure, travis-ci
> Fix For: 0.13.0
>
>
> See https://travis-ci.org/apache/arrow/jobs/500414242#L1002
> {code:javascript}
> ● Table#serialize() › Table#assign with an empty table round-trips through
> serialization
> expect(received).toBe(expected) // Object.is equality
> Expected: 86
> Received: 41
> 91 | const source = table1.assign(Table.empty());
> 92 | expect(source.numCols).toBe(table1.numCols);
> > 93 | expect(source.length).toBe(table1.length);
> | ^
> 94 | const result = Table.from(source.serialize());
> 95 | expect(result).toEqualTable(source);
> 96 |
> expect(result.schema.metadata.get('foo')).toEqual('bar');
> at Object.test (test/unit/table/serialize-tests.ts:93:35)
> ● Table#serialize() › Table#assign with a zero-length Null column
> round-trips through serialization
> expect(received).toBe(expected) // Object.is equality
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
