Phillip Cloud created ARROW-14123:
-------------------------------------

             Summary: [C++] DayTimeIntervalType::DayMilliseconds comparison 
function seems incorrect
                 Key: ARROW-14123
                 URL: https://issues.apache.org/jira/browse/ARROW-14123
             Project: Apache Arrow
          Issue Type: Bug
          Components: C++
            Reporter: Phillip Cloud
             Fix For: 6.0.0


The less than operator ({{operator<}}) implemented on 
{{DayTimeIntervalType::DayMilliseconds}} seems incorrect:

{code:cpp}
    bool operator<(DayMilliseconds other) const {
      return this->days < other.days || this->milliseconds < other.milliseconds;
    }

{code}

With this implementation, an example (in pseudocode) such as 

{code:cpp}
DayMilliseconds { days = 10, milliseconds = 999 } < DayMilliseconds { days = 9, 
milliseconds = 1000 }
{code}

would return {{true}} when it should return {{false}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to