[ https://issues.apache.org/jira/browse/ARROW-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-3487. --------------------------------- Resolution: Fixed Fix Version/s: 0.12.0 Issue resolved by pull request 2840 [https://github.com/apache/arrow/pull/2840] > [Gandiva] simplify NULL_IF_NULL functions that can return errors > ---------------------------------------------------------------- > > Key: ARROW-3487 > URL: https://issues.apache.org/jira/browse/ARROW-3487 > Project: Apache Arrow > Issue Type: Task > Components: Gandiva > Reporter: Pindikura Ravindra > Priority: Major > Labels: pull-request-available > Fix For: 0.12.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > NULL_IF_NULL functions that can return errors eg. divide currently look at > the validity bits in each function (to avoid returning spurious errors). > > {code:java} > divide(TYPE in1, boolean is_valid1, TYPE in2, boolean is_valid2, ..) { > if (!is_valid1 || !is_valid2) { > return 0; > } > if (in2 == 0) { /* set error */ } > } > {code} > > This validity check is duplicated for multiple functions and should be moved > to the common layer (for all NULL_IF_NULL functions that can return error). > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)