[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238717#comment-15238717 ] Micah Kornfield commented on ARROW-100: --- hmm what version, of clang-tidy do you have

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Philipp Moritz (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238688#comment-15238688 ] Philipp Moritz commented on ARROW-100: -- Just added the test and fixed a bug that the t

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238517#comment-15238517 ] Micah Kornfield commented on ARROW-100: --- Also, in the existing unit test there is an

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238507#comment-15238507 ] Micah Kornfield commented on ARROW-100: --- At the moment there isn't you could create a

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Philipp Moritz (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238481#comment-15238481 ] Philipp Moritz commented on ARROW-100: -- Thanks! The implementation is here: https://g

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238413#comment-15238413 ] Micah Kornfield commented on ARROW-100: --- I don't have much experience with flatbuffer

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Philipp Moritz (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238398#comment-15238398 ] Philipp Moritz commented on ARROW-100: -- Thanks for your answers! Looking into it a bi

[jira] [Commented] (ARROW-60) C++: Struct type builder API

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238391#comment-15238391 ] Micah Kornfield commented on ARROW-60: -- A virtual method for AppendNull, but it looks l

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238386#comment-15238386 ] Micah Kornfield commented on ARROW-100: --- Welcome Philip. Your approach sounds correc

[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238304#comment-15238304 ] Kai Zheng commented on ARROW-100: - Sounds good Philipp. I refined the title to avoid confus

[jira] [Updated] (ARROW-100) [C++] Computing RowBatch size

2016-04-12 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Zheng updated ARROW-100: Summary: [C++] Computing RowBatch size (was: Keeping track of final object sizes) > [C++] Computing RowBatc

[jira] [Updated] (ARROW-100) Keeping track of final object sizes

2016-04-12 Thread Philipp Moritz (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Moritz updated ARROW-100: - Description: Hi, thank you guys for this project, I'm really enjoying what I've seen so far! Ther

[jira] [Created] (ARROW-100) Keeping track of final object sizes

2016-04-12 Thread Philipp Moritz (JIRA)
Philipp Moritz created ARROW-100: Summary: Keeping track of final object sizes Key: ARROW-100 URL: https://issues.apache.org/jira/browse/ARROW-100 Project: Apache Arrow Issue Type: New Featur

[jira] [Commented] (ARROW-60) C++: Struct type builder API

2016-04-12 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238096#comment-15238096 ] Kai Zheng commented on ARROW-60: Which virtual method call did you mention? I thought for th

[jira] [Commented] (ARROW-60) C++: Struct type builder API

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236837#comment-15236837 ] Micah Kornfield commented on ARROW-60: -- looking more at the code I think the virtual me

[jira] [Commented] (ARROW-60) C++: Struct type builder API

2016-04-12 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236786#comment-15236786 ] Kai Zheng commented on ARROW-60: Thanks Micah for the sync and review in advance. > C++: St

[jira] [Commented] (ARROW-60) C++: Struct type builder API

2016-04-12 Thread Micah Kornfield (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236728#comment-15236728 ] Micah Kornfield commented on ARROW-60: -- I'm currently not blocked on it. I'm also not