[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240621#comment-15240621 ] Philipp Moritz commented on ARROW-100: -- You were right, I was using an old version of clang-tidy. After updating it, everything worked out nicely, the pull request should be complete now. > [C++] Computing RowBatch size > - > > Key: ARROW-100 > URL: https://issues.apache.org/jira/browse/ARROW-100 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ >Reporter: Philipp Moritz > > Hi, > thank you guys for this project, I'm really enjoying what I've seen so far! > There is an unimplemented method for getting the total size of objects: > int64_t GetRowBatchSize(const RowBatch* batch); > Has somebody already started to implement it or thought about how to do it? > It could be done by recursively adding up all the involved buffer sizes, > build the metadata and add its size. Let me know if you want me to create a > draft of the implementation. > -- Philipp. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARROW-101) Fix java warnings emitted by java compiler
[ https://issues.apache.org/jira/browse/ARROW-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated ARROW-101: - Priority: Trivial (was: Major) > Fix java warnings emitted by java compiler > -- > > Key: ARROW-101 > URL: https://issues.apache.org/jira/browse/ARROW-101 > Project: Apache Arrow > Issue Type: Task >Reporter: Laurent Goujon >Priority: Trivial > > Java compiler emits several warnings regarding the use of rawtypes and > unclosed resources on a few classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARROW-102) travis-ci support for java project
[ https://issues.apache.org/jira/browse/ARROW-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated ARROW-102: - Priority: Minor (was: Major) > travis-ci support for java project > -- > > Key: ARROW-102 > URL: https://issues.apache.org/jira/browse/ARROW-102 > Project: Apache Arrow > Issue Type: Task >Reporter: Laurent Goujon >Priority: Minor > > The java part of the Arrow project has no automated build using travis-ci, > unlike c++. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARROW-102) travis-ci support for java project
Laurent Goujon created ARROW-102: Summary: travis-ci support for java project Key: ARROW-102 URL: https://issues.apache.org/jira/browse/ARROW-102 Project: Apache Arrow Issue Type: Task Reporter: Laurent Goujon The java part of the Arrow project has no automated build using travis-ci, unlike c++. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARROW-101) Fix java warnings emitted by java compiler
[ https://issues.apache.org/jira/browse/ARROW-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated ARROW-101: - Summary: Fix java warnings emitted by java compiler (was: Fix java rawtypes warnings emitted by java compiler) > Fix java warnings emitted by java compiler > -- > > Key: ARROW-101 > URL: https://issues.apache.org/jira/browse/ARROW-101 > Project: Apache Arrow > Issue Type: Task >Reporter: Laurent Goujon > > Java compiler emits several warnings regarding the use of rawtypes on a few > classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARROW-101) Fix java warnings emitted by java compiler
[ https://issues.apache.org/jira/browse/ARROW-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated ARROW-101: - Description: Java compiler emits several warnings regarding the use of rawtypes and unclosed resources on a few classes. (was: Java compiler emits several warnings regarding the use of rawtypes on a few classes.) > Fix java warnings emitted by java compiler > -- > > Key: ARROW-101 > URL: https://issues.apache.org/jira/browse/ARROW-101 > Project: Apache Arrow > Issue Type: Task >Reporter: Laurent Goujon > > Java compiler emits several warnings regarding the use of rawtypes and > unclosed resources on a few classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARROW-101) Fix java rawtypes warnings emitted by java compiler
Laurent Goujon created ARROW-101: Summary: Fix java rawtypes warnings emitted by java compiler Key: ARROW-101 URL: https://issues.apache.org/jira/browse/ARROW-101 Project: Apache Arrow Issue Type: Task Reporter: Laurent Goujon Java compiler emits several warnings regarding the use of rawtypes on a few classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238717#comment-15238717 ] Micah Kornfield commented on ARROW-100: --- hmm what version, of clang-tidy do you have installed? I thought I fixed this issue (at least for clang-tidy-3.7) when I checked in the initial clang-tidy check. It looks like it is following the path that the assertion should checking for, but it doesn't realize that FatalLogger never returns after destruction. > [C++] Computing RowBatch size > - > > Key: ARROW-100 > URL: https://issues.apache.org/jira/browse/ARROW-100 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ >Reporter: Philipp Moritz > > Hi, > thank you guys for this project, I'm really enjoying what I've seen so far! > There is an unimplemented method for getting the total size of objects: > int64_t GetRowBatchSize(const RowBatch* batch); > Has somebody already started to implement it or thought about how to do it? > It could be done by recursively adding up all the involved buffer sizes, > build the metadata and add its size. Let me know if you want me to create a > draft of the implementation. > -- Philipp. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARROW-100) [C++] Computing RowBatch size
[ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238688#comment-15238688 ] Philipp Moritz commented on ARROW-100: -- Just added the test and fixed a bug that the test discovered (I need to compute the actual offset, passing in 0 is not enough); I also addressed your comments (didn't change the 1<<16 because I don't want the test to depend on code that is supposed to be tested). Thanks a lot for your help! The issues clang-tidy found are largely unrelated to what I have been doing, but there is one the was introduced by the code I wrote that I don't really understand: https://gist.github.com/pcmoritz/0ec7421c60140eb47fccd770c2cd280d Any chance you can look at it and help me figure out what is going on? > [C++] Computing RowBatch size > - > > Key: ARROW-100 > URL: https://issues.apache.org/jira/browse/ARROW-100 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ >Reporter: Philipp Moritz > > Hi, > thank you guys for this project, I'm really enjoying what I've seen so far! > There is an unimplemented method for getting the total size of objects: > int64_t GetRowBatchSize(const RowBatch* batch); > Has somebody already started to implement it or thought about how to do it? > It could be done by recursively adding up all the involved buffer sizes, > build the metadata and add its size. Let me know if you want me to create a > draft of the implementation. > -- Philipp. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
