[jira] [Comment Edited] (ARROW-5847) [C++] Remove lazy.h

[ https://issues.apache.org/jira/browse/ARROW-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878606#comment-16878606 ] Dimitri Vorona edited comment on ARROW-5847 at 7/4/19 12:25 PM: It's

[jira] [Commented] (ARROW-5847) [C++] Remove lazy.h

[ https://issues.apache.org/jira/browse/ARROW-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878606#comment-16878606 ] Dimitri Vorona commented on ARROW-5847: --- It's still used

[jira] [Updated] (ARROW-3734) [C++] Linking static zstd library fails on Arch x86-64

[ https://issues.apache.org/jira/browse/ARROW-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-3734: -- Description: zlib installs the static library into the ${CMAKE_INSTALL_LIBDIR} which is lib64

[jira] [Created] (ARROW-3734) [C++] Linking static zstd library fails on Arch x86-64

Dimitri Vorona created ARROW-3734: - Summary: [C++] Linking static zstd library fails on Arch x86-64 Key: ARROW-3734 URL: https://issues.apache.org/jira/browse/ARROW-3734 Project: Apache Arrow

[jira] [Comment Edited] (ARROW-3722) [C++] Allow specifying column types to CSV reader

[ https://issues.apache.org/jira/browse/ARROW-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680956#comment-16680956 ] Dimitri Vorona edited comment on ARROW-3722 at 11/9/18 7:12 AM: Hi

[jira] [Commented] (ARROW-3722) [C++] Allow specifying column types to CSV reader

[ https://issues.apache.org/jira/browse/ARROW-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680956#comment-16680956 ] Dimitri Vorona commented on ARROW-3722: --- Hi Antoinne, I agree with having to supply either every

[jira] [Comment Edited] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670185#comment-16670185 ] Dimitri Vorona edited comment on ARROW-3662 at 10/31/18 2:39 PM: - I was

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670185#comment-16670185 ] Dimitri Vorona commented on ARROW-3662: --- I was on some platforms we used SEEK_END/Tell trick to get

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669966#comment-16669966 ] Dimitri Vorona commented on ARROW-3662: --- > The idea of "const" files is a bit murky in itself :)

[jira] [Created] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

Dimitri Vorona created ARROW-3662: - Summary: [C++] Add a const overload to MemoryMappedFile::GetSize Key: ARROW-3662 URL: https://issues.apache.org/jira/browse/ARROW-3662 Project: Apache Arrow

[jira] [Updated] (ARROW-3660) [C++] Don't unnecessarily lock MemoryMappedFile for resizing in readonly files

[ https://issues.apache.org/jira/browse/ARROW-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-3660: -- Summary: [C++] Don't unnecessarily lock MemoryMappedFile for resizing in readonly files (was:

[jira] [Updated] (ARROW-3660) [C++] Don't unnecessaryly lock MemoryMappedFile for resizing in readonly files

[ https://issues.apache.org/jira/browse/ARROW-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-3660: -- Summary: [C++] Don't unnecessaryly lock MemoryMappedFile for resizing in readonly files (was:

[jira] [Created] (ARROW-3660) [C++] Don't unnecessary lock MemoryMappedFile for resizing in readonly files

Dimitri Vorona created ARROW-3660: - Summary: [C++] Don't unnecessary lock MemoryMappedFile for resizing in readonly files Key: ARROW-3660 URL: https://issues.apache.org/jira/browse/ARROW-3660

[jira] [Comment Edited] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu

[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580379#comment-16580379 ] Dimitri Vorona edited comment on ARROW-3051 at 8/15/18 7:51 AM: In that

[jira] [Comment Edited] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu

[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580379#comment-16580379 ] Dimitri Vorona edited comment on ARROW-3051 at 8/15/18 7:50 AM: In that

[jira] [Comment Edited] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu

[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580379#comment-16580379 ] Dimitri Vorona edited comment on ARROW-3051 at 8/14/18 8:21 PM: In that

[jira] [Commented] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu

[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580379#comment-16580379 ] Dimitri Vorona commented on ARROW-3051: --- In that case copy-elision won't work either 

[jira] [Commented] (ARROW-3051) [C++] Status performance optimization from Impala/Kudu

[ https://issues.apache.org/jira/browse/ARROW-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580232#comment-16580232 ] Dimitri Vorona commented on ARROW-3051: --- If I understand it correctly, there is an abseil tip of

[jira] [Commented] (ARROW-2835) [C++] ReadAt/WriteAt are inconsistent with moving the files position

[ https://issues.apache.org/jira/browse/ARROW-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541962#comment-16541962 ] Dimitri Vorona commented on ARROW-2835: --- Ok, then we should at least be consistent across

[jira] [Created] (ARROW-2837) [C++] ArrayBuilder::null_bitmap returns PoolBuffer

Dimitri Vorona created ARROW-2837: - Summary: [C++] ArrayBuilder::null_bitmap returns PoolBuffer Key: ARROW-2837 URL: https://issues.apache.org/jira/browse/ARROW-2837 Project: Apache Arrow

[jira] [Created] (ARROW-2835) [C++] ReadAt/WriteAt are inconsistent with moving the files position

Dimitri Vorona created ARROW-2835: - Summary: [C++] ReadAt/WriteAt are inconsistent with moving the files position Key: ARROW-2835 URL: https://issues.apache.org/jira/browse/ARROW-2835 Project: Apache

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540028#comment-16540028 ] Dimitri Vorona commented on ARROW-2816: --- I sent a PR with proposed changes. > [Python] Add

[jira] [Assigned] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona reassigned ARROW-2816: - Assignee: Dimitri Vorona > [Python] Add __iter__ method to NativeFile >

[jira] [Comment Edited] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539679#comment-16539679 ] Dimitri Vorona edited comment on ARROW-2816 at 7/11/18 8:06 AM: -On a

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539679#comment-16539679 ] Dimitri Vorona commented on ARROW-2816: --- On a unrelated note: is it normal that I don't receive 

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539676#comment-16539676 ] Dimitri Vorona commented on ARROW-2816: --- Hi Antoine. Since RawIOBase is an ABC, couldn't we just

[jira] [Comment Edited] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539658#comment-16539658 ] Dimitri Vorona edited comment on ARROW-2816 at 7/11/18 7:36 AM: Antoine,

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539658#comment-16539658 ] Dimitri Vorona commented on ARROW-2816: --- Antoine, are you sure? I maybe missunderstand [the

[jira] [Comment Edited] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539658#comment-16539658 ] Dimitri Vorona edited comment on ARROW-2816 at 7/11/18 7:31 AM: Antoine,

[jira] [Comment Edited] (ARROW-2701) [C++] Make MemoryMappedFile resizable

[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539653#comment-16539653 ] Dimitri Vorona edited comment on ARROW-2701 at 7/11/18 7:23 AM: I think

[jira] [Commented] (ARROW-2701) [C++] Make MemoryMappedFile resizable

[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539653#comment-16539653 ] Dimitri Vorona commented on ARROW-2701: --- I think the consensus was that we should solve this

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538862#comment-16538862 ] Dimitri Vorona commented on ARROW-2816: --- We can't subclass Python classes in extension types, can

[jira] [Commented] (ARROW-2822) [C++] Zero padding bytes in PoolBuffer::Resize

[ https://issues.apache.org/jira/browse/ARROW-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538782#comment-16538782 ] Dimitri Vorona commented on ARROW-2822: --- Except for a couple of cases, most of the builder

[jira] [Commented] (ARROW-2822) [C++] Zero padding bytes in PoolBuffer::Resize

[ https://issues.apache.org/jira/browse/ARROW-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538516#comment-16538516 ] Dimitri Vorona commented on ARROW-2822: --- I ended up leaving Buffer::Resize unchanged and explicitly

[jira] [Comment Edited] (ARROW-2822) [C++] Zero padding bytes in PoolBuffer::Resize

[ https://issues.apache.org/jira/browse/ARROW-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538195#comment-16538195 ] Dimitri Vorona edited comment on ARROW-2822 at 7/10/18 9:07 AM: Hi Wes,  

[jira] [Commented] (ARROW-2822) [C++] Zero padding bytes in PoolBuffer::Resize

[ https://issues.apache.org/jira/browse/ARROW-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538294#comment-16538294 ] Dimitri Vorona commented on ARROW-2822: --- But we can then zero padding in AllocateBuffer by default,

[jira] [Commented] (ARROW-2822) [C++] Zero padding bytes in PoolBuffer::Resize

[ https://issues.apache.org/jira/browse/ARROW-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538265#comment-16538265 ] Dimitri Vorona commented on ARROW-2822: --- Ok, thinking further about it: we need to zero the padding

[jira] [Commented] (ARROW-2822) [C++] Zero padding bytes in PoolBuffer::Resize

[ https://issues.apache.org/jira/browse/ARROW-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538195#comment-16538195 ] Dimitri Vorona commented on ARROW-2822: --- Hi Wes,   yeah, this should work. We'd still have to

[jira] [Updated] (ARROW-2790) [C++] Buffers contain uninitialized memory

[ https://issues.apache.org/jira/browse/ARROW-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2790: -- Description: Hi, currently, buffers can contain uninitalized memory when built with buffer

[jira] [Updated] (ARROW-2790) [C++] Buffers contain uninitialized memory

[ https://issues.apache.org/jira/browse/ARROW-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2790: -- Description: Hi, currently, buffers can contain uninitalized memory when built with buffer

[jira] [Created] (ARROW-2790) [C++] Buffers contain uninitialized memory

Dimitri Vorona created ARROW-2790: - Summary: [C++] Buffers contain uninitialized memory Key: ARROW-2790 URL: https://issues.apache.org/jira/browse/ARROW-2790 Project: Apache Arrow Issue

[jira] [Comment Edited] (ARROW-2785) [C++] Crash in json-integration-test

[ https://issues.apache.org/jira/browse/ARROW-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531209#comment-16531209 ] Dimitri Vorona edited comment on ARROW-2785 at 7/3/18 11:12 AM: I've

[jira] [Commented] (ARROW-2785) [C++] Crash in json-integration-test

[ https://issues.apache.org/jira/browse/ARROW-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531209#comment-16531209 ] Dimitri Vorona commented on ARROW-2785: --- I've written about second valgrind warning to the mailing

[jira] [Comment Edited] (ARROW-2785) [C++] Crash in json-integration-test

[ https://issues.apache.org/jira/browse/ARROW-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531051#comment-16531051 ] Dimitri Vorona edited comment on ARROW-2785 at 7/3/18 9:25 AM: --- The (edit:

[jira] [Commented] (ARROW-2785) [C++] Crash in json-integration-test

[ https://issues.apache.org/jira/browse/ARROW-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531051#comment-16531051 ] Dimitri Vorona commented on ARROW-2785: --- The valgrind warning seem unrelated: it is produced in

[jira] [Commented] (ARROW-2785) [C++] Crash in json-integration-test

[ https://issues.apache.org/jira/browse/ARROW-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530492#comment-16530492 ] Dimitri Vorona commented on ARROW-2785: --- H,   TestJSONIntegration.ConvertAndValidate also throws a

[jira] [Comment Edited] (ARROW-2785) [C++] Crash in json-integration-test

[ https://issues.apache.org/jira/browse/ARROW-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530492#comment-16530492 ] Dimitri Vorona edited comment on ARROW-2785 at 7/2/18 10:10 PM: H,  

[jira] [Updated] (ARROW-2784) [C++] MemoryMappedFile::WriteAt allow writing past the end

[ https://issues.apache.org/jira/browse/ARROW-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2784: -- External issue URL: https://github.com/apache/arrow/pull/2206 > [C++]

[jira] [Created] (ARROW-2784) [C++] MemoryMappedFile::WriteAt allow writing past the end

Dimitri Vorona created ARROW-2784: - Summary: [C++] MemoryMappedFile::WriteAt allow writing past the end Key: ARROW-2784 URL: https://issues.apache.org/jira/browse/ARROW-2784 Project: Apache Arrow

[jira] [Updated] (ARROW-2701) [C++] Make MemoryMappedFile resizable

[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2701: -- External issue URL: https://github.com/apache/arrow/pull/2205 (was:

[jira] [Commented] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520268#comment-16520268 ] Dimitri Vorona commented on ARROW-2400: --- What did actually happen of it? 200ns per command saved by

[jira] [Updated] (ARROW-2701) [C++] Make MemoryMappedFile resizable

[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2701: -- External issue URL: https://github.com/apache/arrow/pull/2134 > [C++] Make MemoryMappedFile

[jira] [Created] (ARROW-2701) [C++] Make MemoryMappedFile resizable

Dimitri Vorona created ARROW-2701: - Summary: [C++] Make MemoryMappedFile resizable Key: ARROW-2701 URL: https://issues.apache.org/jira/browse/ARROW-2701 Project: Apache Arrow Issue Type: New

[jira] [Commented] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426908#comment-16426908 ] Dimitri Vorona commented on ARROW-2400: --- With the predict patch

[jira] [Comment Edited] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426845#comment-16426845 ] Dimitri Vorona edited comment on ARROW-2400 at 4/5/18 12:58 PM:

[jira] [Commented] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426845#comment-16426845 ] Dimitri Vorona commented on ARROW-2400: --- CompilerExplorer for clang: [https://godbolt.org/g/kx1pnp]

[jira] [Comment Edited] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426774#comment-16426774 ] Dimitri Vorona edited comment on ARROW-2400 at 4/5/18 11:47 AM: Hi

[jira] [Comment Edited] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426774#comment-16426774 ] Dimitri Vorona edited comment on ARROW-2400 at 4/5/18 11:46 AM: Hi

[jira] [Comment Edited] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426774#comment-16426774 ] Dimitri Vorona edited comment on ARROW-2400 at 4/5/18 11:36 AM: Hi

[jira] [Commented] (ARROW-2400) [C++] Status destructor is expensive

[ https://issues.apache.org/jira/browse/ARROW-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426774#comment-16426774 ] Dimitri Vorona commented on ARROW-2400: --- Hi Antoine, this is something I've noticed before, but

[jira] [Created] (ARROW-2330) Optimize delta buffer creation with partially finishable array builders

Dimitri Vorona created ARROW-2330: - Summary: Optimize delta buffer creation with partially finishable array builders Key: ARROW-2330 URL: https://issues.apache.org/jira/browse/ARROW-2330 Project:

[jira] [Comment Edited] (ARROW-2274) ObjectID from string

[ https://issues.apache.org/jira/browse/ARROW-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387799#comment-16387799 ] Dimitri Vorona edited comment on ARROW-2274 at 3/6/18 1:51 PM: --- Could you

[jira] [Commented] (ARROW-2274) ObjectID from string

[ https://issues.apache.org/jira/browse/ARROW-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387799#comment-16387799 ] Dimitri Vorona commented on ARROW-2274: --- Could you provide your code? {{ plasma::ObjectID object_id

[jira] [Updated] (ARROW-2176) [C++] Extend DictionaryBuilder to support delta dictionaries

[ https://issues.apache.org/jira/browse/ARROW-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Vorona updated ARROW-2176: -- External issue URL: https://github.com/apache/arrow/pull/1629 > [C++] Extend DictionaryBuilder

[jira] [Created] (ARROW-2176) [C++] Extend DictionaryBuilder to support delta dictionaries

Dimitri Vorona created ARROW-2176: - Summary: [C++] Extend DictionaryBuilder to support delta dictionaries Key: ARROW-2176 URL: https://issues.apache.org/jira/browse/ARROW-2176 Project: Apache Arrow