[jira] [Commented] (ARROW-2109) [C++] Boost 1.66 compilation fails on Windows on linkage stage
[ https://issues.apache.org/jira/browse/ARROW-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355869#comment-16355869 ] ASF GitHub Bot commented on ARROW-2109: --- wesm commented on issue #1567: ARROW-2109: [C++] Completely disable boost autolink on MSVC build URL: https://github.com/apache/arrow/pull/1567#issuecomment-363868606 thanks @MaxRis! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] Boost 1.66 compilation fails on Windows on linkage stage > -- > > Key: ARROW-2109 > URL: https://issues.apache.org/jira/browse/ARROW-2109 > Project: Apache Arrow > Issue Type: Bug > Environment: Windows >Reporter: Max Risuhin >Assignee: Max Risuhin >Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > Boost's autolinking should be disable on compilation with MSVC, since it > causes linkage with shared import libs, instead of expected static. Following > error occurs: > `LINK : fatal error LNK1104: cannot open file 'boost_filesystem.lib'` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2109) [C++] Boost 1.66 compilation fails on Windows on linkage stage
[
https://issues.apache.org/jira/browse/ARROW-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355513#comment-16355513
]
ASF GitHub Bot commented on ARROW-2109:
---
xhochy closed pull request #1567: ARROW-2109: [C++] Completely disable boost
autolink on MSVC build
URL: https://github.com/apache/arrow/pull/1567
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 69812b97c..374c65207 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -136,6 +136,7 @@ if (MSVC AND ARROW_USE_STATIC_CRT)
set(Boost_USE_STATIC_RUNTIME ON)
endif()
set(Boost_ADDITIONAL_VERSIONS
+ "1.66.0" "1.66"
"1.65.0" "1.65"
"1.64.0" "1.64"
"1.63.0" "1.63"
@@ -192,14 +193,15 @@ if (ARROW_BOOST_VENDORED)
set(Boost_INCLUDE_DIRS "${BOOST_INCLUDE_DIR}")
add_dependencies(arrow_dependencies boost_ep)
else()
+ if (MSVC)
+# disable autolinking in boost
+add_definitions(-DBOOST_ALL_NO_LIB)
+ endif()
if (ARROW_BOOST_USE_SHARED)
# Find shared Boost libraries.
set(Boost_USE_STATIC_LIBS OFF)
-if(MSVC)
- # disable autolinking in boost
- add_definitions(-DBOOST_ALL_NO_LIB)
-
+if (MSVC)
# force all boost libraries to dynamic link
add_definitions(-DBOOST_ALL_DYN_LINK)
endif()
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Boost 1.66 compilation fails on Windows on linkage stage
> --
>
> Key: ARROW-2109
> URL: https://issues.apache.org/jira/browse/ARROW-2109
> Project: Apache Arrow
> Issue Type: Bug
> Environment: Windows
>Reporter: Max Risuhin
>Assignee: Max Risuhin
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Boost's autolinking should be disable on compilation with MSVC, since it
> causes linkage with shared import libs, instead of expected static. Following
> error occurs:
> `LINK : fatal error LNK1104: cannot open file 'boost_filesystem.lib'`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2109) [C++] Boost 1.66 compilation fails on Windows on linkage stage
[ https://issues.apache.org/jira/browse/ARROW-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355236#comment-16355236 ] ASF GitHub Bot commented on ARROW-2109: --- MaxRis opened a new pull request #1567: ARROW-2109: [C++] Completely disable boost autolink on MSVC build URL: https://github.com/apache/arrow/pull/1567 Boost's autolink disabling solves linkage issues appeared with boost v.1.66.0 (in case of linkage with static boost libs) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] Boost 1.66 compilation fails on Windows on linkage stage > -- > > Key: ARROW-2109 > URL: https://issues.apache.org/jira/browse/ARROW-2109 > Project: Apache Arrow > Issue Type: Bug > Environment: Windows >Reporter: Max Risuhin >Assignee: Max Risuhin >Priority: Major > Labels: pull-request-available > > Boost's autolinking should be disable on compilation with MSVC, since it > causes linkage with shared import libs, instead of expected static. Following > error occurs: > `LINK : fatal error LNK1104: cannot open file 'boost_filesystem.lib'` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
