[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721208#comment-16721208 ] Pindikura Ravindra commented on ARROW-3701: --- As part of my PR, I'm adding more benchmarks to

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720561#comment-16720561 ] Wes McKinney commented on ARROW-3701: - Will these benchmarks be in the Arrow codebase somewhere?

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717008#comment-16717008 ] Pindikura Ravindra commented on ARROW-3701: --- After running more benchmarks, I found the

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681704#comment-16681704 ] Pindikura Ravindra commented on ARROW-3701: --- @wesm - I tried the same cmd on my windows 10 home

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678799#comment-16678799 ] Wes McKinney commented on ARROW-3701: - Did you try on Windows? If not I can give it a try >

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676963#comment-16676963 ] Antoine Pitrou commented on ARROW-3701: --- > Is this documented somewhere? I don't know. That was

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676112#comment-16676112 ] Pindikura Ravindra commented on ARROW-3701: --- > Also note that Boost has a 128-bit integer type,

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675804#comment-16675804 ] Jacques Nadeau commented on ARROW-3701: --- Thanks for the explanations/pointers Antoine. This

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675753#comment-16675753 ] Antoine Pitrou commented on ARROW-3701: --- > From an IR perspective, we probably want to map down to

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675746#comment-16675746 ] Antoine Pitrou commented on ARROW-3701: --- LLVM IR is generally not cross-platform, as it will encode

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675728#comment-16675728 ] Jacques Nadeau commented on ARROW-3701: --- {quote}However, we'll need to keep a standards-compliant

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675684#comment-16675684 ] Antoine Pitrou commented on ARROW-3701: --- Also note that Boost has a 128-bit integer type, though I

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675665#comment-16675665 ] Antoine Pitrou commented on ARROW-3701: --- That sounds like a nice improvement indeed. However, we'll

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675643#comment-16675643 ] Pindikura Ravindra commented on ARROW-3701: --- I ran a simple test on my desktop (macbook pro) to

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675008#comment-16675008 ] Pindikura Ravindra commented on ARROW-3701: --- > CPUs generally don't have 128 bit integer

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674947#comment-16674947 ] Antoine Pitrou commented on ARROW-3701: --- > This class is built on a pair of int64s - using a int128

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674918#comment-16674918 ] Pindikura Ravindra commented on ARROW-3701: --- ok, I'll make sure that this code works on windows

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674831#comment-16674831 ] Wes McKinney commented on ARROW-3701: - The Impala code is not cross platform. We need to make sure

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674787#comment-16674787 ] Pindikura Ravindra commented on ARROW-3701: --- @wesm @cpcloud [~pitrou] @jacques-n