[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-23 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1164433932 Removed the "old" metadata methods in favor of the new one. I'll merge this for now but we can keep iterating. Thanks Kirill! -- This is an automated message from the Apache Git

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-21 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1161903416 Implemented for SQLite, though the constraint metadata ignores the column name filter for simplicity. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-20 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1160634749 Ah, something more like this then? ``` /// CONSTRAINT_SCHEMA is a Struct with fields: /// /// Field Name | Field Type| Comments ///

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-20 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1160481520 Is something like this what you were thinking? (This has less information than what Flight SQL provides but feels minimal, unless we also want to reflect the cascade/delete rules)

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-19 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1159733606 Since we have all the other metadata here, I think it's reasonable to add that information as well. So the 'tables' would now be something like: ``` table_name: utf8

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-17 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1159135921 Implemented for SQLite. It's a little tedious to implement for SQLite but isn't especially complicated, at least. -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-16 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1158040008 Hmm, the filters (at least currently, and in Flight SQL) can be patterns as well as fixed strings. If filtering by catalog name gives you the schemas directly, that starts to

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-16 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1158027202 Hmm, that sounds reasonable. So the schema would be something like this? ``` catalog_name: utf8 catalog_schemas: list>> ``` And if you filtered by (say)

[GitHub] [arrow-adbc] lidavidm commented on pull request #18: Add table/column reflection

2022-06-15 Thread GitBox
lidavidm commented on PR #18: URL: https://github.com/apache/arrow-adbc/pull/18#issuecomment-1156813679 CC @hannes, @krlmlr. This is roughly patterned off of Flight SQL (and seems similarish to DBI from quick look as well) I think we discussed an MSSQL style `information_schema` or