[GitHub] [arrow-nanoarrow] lidavidm commented on pull request #10: Implement bitmap setters, getters, and element-wise builder

lidavidm commented on PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1204391711 > I'm not sure which buffer you mean! The `struct ArrowBuffer`? Sorry, I mean the buffer of values inside the bitmap builder -- This is an automated message from the Apache

[GitHub] [arrow-nanoarrow] lidavidm commented on pull request #10: Implement bitmap setters, getters, and element-wise builder

lidavidm commented on PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1204107639 But if it's easier to do things in stages then we can just review the current PR? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow-nanoarrow] lidavidm commented on pull request #10: Implement bitmap setters, getters, and element-wise builder

lidavidm commented on PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1204106882 I don't think we need to split up header files or rearrange things, though, and I don't think we need to inline the buffer functions - it could just be moving the definitions from

[GitHub] [arrow-nanoarrow] lidavidm commented on pull request #10: Implement bitmap setters, getters, and element-wise builder

lidavidm commented on PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1203133106 I guess the general comment is: as Wes suggests, many of these should be defined inline in the header so they can get inlined into the caller, right? -- This is an automated