[GitHub] [arrow-testing] pitrou commented on pull request #56: ARROW-11417: Add integration files for buffer compression

2022-06-28 Thread GitBox
pitrou commented on PR #56: URL: https://github.com/apache/arrow-testing/pull/56#issuecomment-1168754007 @liukun4515 The compression file was generated using Arrow C++ IIRC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-testing] pitrou commented on pull request #56: ARROW-11417: Add integration files for buffer compression

2021-02-03 Thread GitBox
pitrou commented on pull request #56: URL: https://github.com/apache/arrow-testing/pull/56#issuecomment-772679327 I renamed to "2.0.0-compression", will merge. This is an automated message from the Apache Git Service. To

[GitHub] [arrow-testing] pitrou commented on pull request #56: ARROW-11417: Add integration files for buffer compression

2021-02-03 Thread GitBox
pitrou commented on pull request #56: URL: https://github.com/apache/arrow-testing/pull/56#issuecomment-772679092 > Strange, I wonder why main integration tests aren't broken for the JSON issue. Because the JSON files that are used in the integration tests are generated by the

[GitHub] [arrow-testing] pitrou commented on pull request #56: ARROW-11417: Add integration files for buffer compression

2021-02-03 Thread GitBox
pitrou commented on pull request #56: URL: https://github.com/apache/arrow-testing/pull/56#issuecomment-772617773 Ok, I edited the JSON files by hand to remove the offending field and now Java manages to read them (**cringe**), though it fails to instantiate the compression: ```

[GitHub] [arrow-testing] pitrou commented on pull request #56: ARROW-11417: Add integration files for buffer compression

2021-02-03 Thread GitBox
pitrou commented on pull request #56: URL: https://github.com/apache/arrow-testing/pull/56#issuecomment-772601749 The JSON files are refused by the Java Arrow integration test: ``` Incompatible files Expected END_OBJECT but got FIELD_NAME 16:30:12.557 [main] ERROR

[GitHub] [arrow-testing] pitrou commented on pull request #56: ARROW-11417: Add integration files for buffer compression

2021-02-03 Thread GitBox
pitrou commented on pull request #56: URL: https://github.com/apache/arrow-testing/pull/56#issuecomment-772592633 I'm not sure what the naming scheme should be. I chose "1.0.0" for the format version, but is it the Arrow library version that generated the files instead? (in which case it