[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

2018-10-31 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670225#comment-16670225 ] Antoine Pitrou commented on ARROW-3662: --- > We do however call seek on the fd in som

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

2018-10-31 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670185#comment-16670185 ] Dimitri Vorona commented on ARROW-3662: --- I was on some platforms we used SEEK_END/T

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

2018-10-31 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670156#comment-16670156 ] Francois Saint-Jacques commented on ARROW-3662: --- Why can't the GetSize can'

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

2018-10-31 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669966#comment-16669966 ] Dimitri Vorona commented on ARROW-3662: --- > The idea of "const" files is a bit murky

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

2018-10-31 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669939#comment-16669939 ] Antoine Pitrou commented on ARROW-3662: --- cc'ing [~fsaintjacques], who might have an

[jira] [Commented] (ARROW-3662) [C++] Add a const overload to MemoryMappedFile::GetSize

2018-10-31 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669938#comment-16669938 ] Antoine Pitrou commented on ARROW-3662: --- I'm not sure what the point would be. The