[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721208#comment-16721208 ] Pindikura Ravindra commented on ARROW-3701: --- As part of my PR, I'm adding more

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720561#comment-16720561 ] Wes McKinney commented on ARROW-3701: - Will these benchmarks be in the Arrow codebase

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717008#comment-16717008 ] Pindikura Ravindra commented on ARROW-3701: --- After running more benchmarks, I f

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681704#comment-16681704 ] Pindikura Ravindra commented on ARROW-3701: --- @wesm - I tried the same cmd on my

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678799#comment-16678799 ] Wes McKinney commented on ARROW-3701: - Did you try on Windows? If not I can give it a

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676963#comment-16676963 ] Antoine Pitrou commented on ARROW-3701: --- > Is this documented somewhere? I don't k

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676112#comment-16676112 ] Pindikura Ravindra commented on ARROW-3701: --- > Also note that Boost has a 128-b

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675804#comment-16675804 ] Jacques Nadeau commented on ARROW-3701: --- Thanks for the explanations/pointers Antoi

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675753#comment-16675753 ] Antoine Pitrou commented on ARROW-3701: --- > From an IR perspective, we probably want

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675746#comment-16675746 ] Antoine Pitrou commented on ARROW-3701: --- LLVM IR is generally not cross-platform, a

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675736#comment-16675736 ] Wes McKinney commented on ARROW-3701: - If the generated IR is indeed cross-platform,

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675728#comment-16675728 ] Jacques Nadeau commented on ARROW-3701: --- {quote}However, we'll need to keep a stand

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675684#comment-16675684 ] Antoine Pitrou commented on ARROW-3701: --- Also note that Boost has a 128-bit integer

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675665#comment-16675665 ] Antoine Pitrou commented on ARROW-3701: --- That sounds like a nice improvement indeed

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675643#comment-16675643 ] Pindikura Ravindra commented on ARROW-3701: --- I ran a simple test on my desktop

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675008#comment-16675008 ] Pindikura Ravindra commented on ARROW-3701: --- > CPUs generally don't have 128 bi

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674947#comment-16674947 ] Antoine Pitrou commented on ARROW-3701: --- > This class is built on a pair of int64s

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674918#comment-16674918 ] Pindikura Ravindra commented on ARROW-3701: --- ok, I'll make sure that this code

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674831#comment-16674831 ] Wes McKinney commented on ARROW-3701: - The Impala code is not cross platform. We need

[jira] [Commented] (ARROW-3701) [Gandiva] Add support for decimal operations

[ https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674787#comment-16674787 ] Pindikura Ravindra commented on ARROW-3701: --- @wesm @cpcloud [~pitrou] @jacques-