[jira] [Commented] (ARROW-4842) [C++] Persist CMake options in pkg-config files
[
https://issues.apache.org/jira/browse/ARROW-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791551#comment-16791551
]
Uwe L. Korn commented on ARROW-4842:
Thanks for this input, will close this then as WONTFIX.
> [C++] Persist CMake options in pkg-config files
> ---
>
> Key: ARROW-4842
> URL: https://issues.apache.org/jira/browse/ARROW-4842
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Packaging
>Reporter: Uwe L. Korn
>Assignee: Uwe L. Korn
>Priority: Major
> Fix For: 0.14.0
>
>
> Persist options like ARROW_WITH_ZSTD in {{arrow.pc}} so libraries can
> determine which features are available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4842) [C++] Persist CMake options in pkg-config files
[
https://issues.apache.org/jira/browse/ARROW-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791017#comment-16791017
]
Kouhei Sutou commented on ARROW-4842:
-
Hmm. It seems that this is not a good idea.
For {{ARROW_WITH_ZSTD}}, we should generate {{arrow/feature.h}} by
{{configure_file}} instead of putting {{-DARROW_WITH_ZSTD}}. (This will be done
by ARROW-4840?)
For {{ARROW_PARQUET}}, users should use {{pkg-config --cflags --libs parquet}}.
If the command returns non-zero, {{ARROW_PARQUET}} was {{OFF}}. (This is
already done by providing separated {{.pc}} such as {{arrow.pc}},
{{parquet.pc}} and {{arrow-orc.pc}}.)
> [C++] Persist CMake options in pkg-config files
> ---
>
> Key: ARROW-4842
> URL: https://issues.apache.org/jira/browse/ARROW-4842
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Packaging
>Reporter: Uwe L. Korn
>Assignee: Uwe L. Korn
>Priority: Major
> Fix For: 0.14.0
>
>
> Persist options like ARROW_WITH_ZSTD in {{arrow.pc}} so libraries can
> determine which features are available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4842) [C++] Persist CMake options in pkg-config files
[
https://issues.apache.org/jira/browse/ARROW-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790718#comment-16790718
]
Uwe L. Korn commented on ARROW-4842:
[~kou] Does this make sense? I have seen this in CMake configs and headers but
never have seen available features defined in a pkg-config file.
> [C++] Persist CMake options in pkg-config files
> ---
>
> Key: ARROW-4842
> URL: https://issues.apache.org/jira/browse/ARROW-4842
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Packaging
>Reporter: Uwe L. Korn
>Assignee: Uwe L. Korn
>Priority: Major
> Fix For: 0.14.0
>
>
> Persist options like ARROW_WITH_ZSTD in {{arrow.pc}} so libraries can
> determine which features are available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
