[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864440#comment-16864440 ] Wes McKinney commented on ARROW-5474: - Handling this separately in ARROW-5615 > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Wes McKinney >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[
https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864416#comment-16864416
]
Wes McKinney commented on ARROW-5474:
-
This is a new one on me... it seems gcc 5.4.0 is pickier about string literals
{code}
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:543:9: error: missing terminating
" character [-Werror]
ASSERT_OK(ArrayFromJSON(type, R"delim(
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:543:2: error: missing terminating
" character
ASSERT_OK(ArrayFromJSON(type, R"delim(
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:550:1: error: stray '\' in program
)delim",
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:617:9: error: missing terminating
" character [-Werror]
ASSERT_OK(ArrayFromJSON(type, R"delim(
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:617:2: error: missing terminating
" character
ASSERT_OK(ArrayFromJSON(type, R"delim(
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:622:9: error: stray '\' in program
[null, "empty"]
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:622:17: error: missing terminating
" character [-Werror]
[null, "empty"]
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:622:9: error: missing terminating
" character
[null, "empty"]
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:630:9: error: stray '\' in program
["bootstrapping tautology?", "lispy", null, "i can see eternity"]
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:630:11: error: missing terminating
" character [-Werror]
["bootstrapping tautology?", "lispy", null, "i can see eternity"]
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:630:9: error: missing terminating
" character
["bootstrapping tautology?", "lispy", null, "i can see eternity"]
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:635:1: error: stray '\' in program
)delim",
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc: In member function 'virtual void
arrow::ipc::internal::json::TestMap_IntegerToInteger_Test::TestBody()':
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:544:1: error: two consecutive '['
shall only introduce an attribute before '[' token
[
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:544:1: error: return-statement
with a value, in function returning 'void' [-fpermissive]
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:544:1: error: expected ';' before
'[' token
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:545:6: error: expected ']' before
'[' token
[[0, 1], [1, 1], [2, 2], [3, 3], [4, 5], [5, 8]],
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc: In member function 'virtual void
arrow::ipc::internal::json::TestMap_IntegerMapToStringList_Test::TestBody()':
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:618:1: error: two consecutive '['
shall only introduce an attribute before '[' token
[
^
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:618:1: error: return-statement
with a value, in function returning 'void' [-fpermissive]
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:618:1: error: expected ';' before
'[' token
/arrow/cpp/src/arrow/ipc/json-simple-test.cc:620:7: error: expected ']' before
'[' token
[
{code}
> [C++] What version of Boost do we require now?
> --
>
> Key: ARROW-5474
> URL: https://issues.apache.org/jira/browse/ARROW-5474
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Neal Richardson
>Assignee: Wes McKinney
>Priority: Major
> Fix For: 0.14.0
>
>
> See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One
> possible cause for that error is that the local filesystem patch increased
> the version of boost that we actually require. The boost version (1.54 vs
> 1.58) was one difference between failure and success.
> Another point of confusion was that CMake reported two different versions of
> boost at different times.
> If we require a minimum version of boost, can we document that better, check
> for it more accurately in the build scripts, and fail with a useful message
> if that minimum isn't met? Or something else helpful.
> If the actual cause of the failure was something else (e.g. compiler
> version), we should figure that out too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864410#comment-16864410 ] Wes McKinney commented on ARROW-5474: - Looking at this. Our build is also broken on Xenial gcc 5.4.0 > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Wes McKinney >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854820#comment-16854820 ] Neal Richardson commented on ARROW-5474: Boost 1.58 seemed to be sufficient in the build I was fighting last week. Fine by me if we declare that the minimum, so that still leaves two tasks: (1) fail with a useful message in CMake if boost is < 1.58, and (2) resolve why it later reported that boost 1.67 was present. > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Antoine Pitrou >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854692#comment-16854692 ] Wes McKinney commented on ARROW-5474: - That's also fine with me. We have https://github.com/apache/arrow/blob/master/cpp/Dockerfile.ubuntu-xenial to help maintain this support, is running that sufficient to check? > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Antoine Pitrou >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854687#comment-16854687 ] Uwe L. Korn commented on ARROW-5474: For adoption reasons, it would be nice to use Ubuntu 16.04 as a baseline. This has Boost 1.58. > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Antoine Pitrou >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854159#comment-16854159 ] Wes McKinney commented on ARROW-5474: - I'm fine with requiring a recent version since we offer a vendored build option > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Antoine Pitrou >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[
https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853675#comment-16853675
]
Antoine Pitrou commented on ARROW-5474:
---
And from this other FAQ
(https://www.boost.org/doc/libs/1_70_0/doc/html/boost_dll/f_a_q_.html -- there
are several of them??):
{quote}Library only guarantees that alias names created using the
BOOST_DLL_ALIAS macros will not change with the change of compiler or platform.
You must take care of functions ABI and API stability by your own. {quote}
> [C++] What version of Boost do we require now?
> --
>
> Key: ARROW-5474
> URL: https://issues.apache.org/jira/browse/ARROW-5474
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Neal Richardson
>Assignee: Antoine Pitrou
>Priority: Major
> Fix For: 0.14.0
>
>
> See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One
> possible cause for that error is that the local filesystem patch increased
> the version of boost that we actually require. The boost version (1.54 vs
> 1.58) was one difference between failure and success.
> Another point of confusion was that CMake reported two different versions of
> boost at different times.
> If we require a minimum version of boost, can we document that better, check
> for it more accurately in the build scripts, and fail with a useful message
> if that minimum isn't met? Or something else helpful.
> If the actual cause of the failure was something else (e.g. compiler
> version), we should figure that out too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[
https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853674#comment-16853674
]
Antoine Pitrou commented on ARROW-5474:
---
>From the Boost FAQ (https://www.boost.org/users/faq.html):
{quote}The scheme is x.y.z, where x is incremented only for massive changes,
such as a reorganization of many libraries, y is incremented whenever a new
library is added, and z is incremented for maintenance releases.{quote}
The FAQ also does not mention API stability.
> [C++] What version of Boost do we require now?
> --
>
> Key: ARROW-5474
> URL: https://issues.apache.org/jira/browse/ARROW-5474
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Neal Richardson
>Assignee: Antoine Pitrou
>Priority: Major
> Fix For: 0.14.0
>
>
> See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One
> possible cause for that error is that the local filesystem patch increased
> the version of boost that we actually require. The boost version (1.54 vs
> 1.58) was one difference between failure and success.
> Another point of confusion was that CMake reported two different versions of
> boost at different times.
> If we require a minimum version of boost, can we document that better, check
> for it more accurately in the build scripts, and fail with a useful message
> if that minimum isn't met? Or something else helpful.
> If the actual cause of the failure was something else (e.g. compiler
> version), we should figure that out too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853649#comment-16853649 ] Antoine Pitrou commented on ARROW-5474: --- AFAIU, Boost is a fast moving library (I'm not sure they guarantee API stability?), so IMO it makes sense to require a recent version. > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Antoine Pitrou >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5474) [C++] What version of Boost do we require now?
[ https://issues.apache.org/jira/browse/ARROW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853481#comment-16853481 ] Wes McKinney commented on ARROW-5474: - We don't have much regular feedback about older Boost versions, it mainly happens around releases, though it would not be a huge effort to set up a Docker job to test with the Boost versions coming from different Linux distributions. Gandiva doesn't build with Boost 1.54 on Ubuntu 14.04, for example, see ARROW-4868 > [C++] What version of Boost do we require now? > -- > > Key: ARROW-5474 > URL: https://issues.apache.org/jira/browse/ARROW-5474 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Neal Richardson >Assignee: Antoine Pitrou >Priority: Major > Fix For: 0.14.0 > > > See debugging on https://issues.apache.org/jira/browse/ARROW-5470. One > possible cause for that error is that the local filesystem patch increased > the version of boost that we actually require. The boost version (1.54 vs > 1.58) was one difference between failure and success. > Another point of confusion was that CMake reported two different versions of > boost at different times. > If we require a minimum version of boost, can we document that better, check > for it more accurately in the build scripts, and fail with a useful message > if that minimum isn't met? Or something else helpful. > If the actual cause of the failure was something else (e.g. compiler > version), we should figure that out too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
