[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-12-04 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988129#comment-16988129 ] Antoine Pitrou commented on ARROW-5508: --- Is there something left to do here? It seems the

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-09-06 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924598#comment-16924598 ] Wes McKinney commented on ARROW-5508: - Moved out of 0.15.0 as it seems like there is more thinking to

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-08-28 Thread Benjamin Kietzman (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917771#comment-16917771 ] Benjamin Kietzman commented on ARROW-5508: -- I think the existing interface is sufficient for our

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-08-28 Thread Micah Kornfield (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917538#comment-16917538 ] Micah Kornfield commented on ARROW-5508: My only comment on this is might pay to sketch out what

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-08-26 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916031#comment-16916031 ] Antoine Pitrou commented on ARROW-5508: --- We could also take a page from Python and have a special

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-08-26 Thread Francois Saint-Jacques (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916021#comment-16916021 ] Francois Saint-Jacques commented on ARROW-5508: --- ping for input: [~pitrou] [~bkietz]

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-08-22 Thread Francois Saint-Jacques (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913838#comment-16913838 ] Francois Saint-Jacques commented on ARROW-5508: --- My take after implementing MapIterator,

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-08-22 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913772#comment-16913772 ] Wes McKinney commented on ARROW-5508: - [~pitrou] [~bkietz] [~fsaintjacques] is the {{Iterator}} in

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-06-19 Thread Benjamin Kietzman (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867739#comment-16867739 ] Benjamin Kietzman commented on ARROW-5508: -- 3. A separate out parameter of type {{bool*}}

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-06-19 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867492#comment-16867492 ] Liya Fan commented on ARROW-5508: - I still have not figured out how to check the end of the iterator by

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-06-14 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864368#comment-16864368 ] Wes McKinney commented on ARROW-5508: - Let's wait until {{StatusOr}} lands and evaluate options. It

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-06-14 Thread Benjamin Kietzman (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864152#comment-16864152 ] Benjamin Kietzman commented on ARROW-5508: -- Why not just use the [{{Range}}

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-06-13 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863415#comment-16863415 ] Wes McKinney commented on ARROW-5508: - I added a prototype for this here, see the comment on the Next

[jira] [Commented] (ARROW-5508) [C++] Create reusable Iterator interface

2019-06-04 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856229#comment-16856229 ] Liya Fan commented on ARROW-5508: - [~wesmckinn], thanks for the good point. What is the standard way to