[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914439#comment-16914439 ] Antoine Pitrou commented on ARROW-5691: --- Ah... Then perhaps the Parquet-Arrow bridge needs to be in

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914438#comment-16914438 ] Wes McKinney commented on ARROW-5691: - I'm OK to leave things as they are now, since it's not really

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914384#comment-16914384 ] Antoine Pitrou commented on ARROW-5691: --- If we have a "formats" directory I'd still like to have

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914378#comment-16914378 ] Wes McKinney commented on ARROW-5691: - We can also flatten these directories and instead use

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914381#comment-16914381 ] Wes McKinney commented on ARROW-5691: - We still have the problem of which shared library to put the

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914337#comment-16914337 ] Antoine Pitrou commented on ARROW-5691: --- Then "formats" plural, because "format" singular sounds

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Francois Saint-Jacques (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914327#comment-16914327 ] Francois Saint-Jacques commented on ARROW-5691: --- I prefer `src/arrow/format`, where we'd

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914320#comment-16914320 ] Antoine Pitrou commented on ARROW-5691: --- Inside "src/arrow/dataset" directory, intuitively I'd only

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914317#comment-16914317 ] Antoine Pitrou commented on ARROW-5691: --- I also dislike the "adapters" name (too generic, it could

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-23 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914304#comment-16914304 ] Wes McKinney commented on ARROW-5691: - FWIW I dislike the "adapters" name and I don't know that the

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-22 Thread Micah Kornfield (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913863#comment-16913863 ] Micah Kornfield commented on ARROW-5691: Given the current organization of the code base and

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-08-22 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913778#comment-16913778 ] Wes McKinney commented on ARROW-5691: - [~emkornfi...@gmail.com] [~pitrou] thoughts about organizing

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-06-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870675#comment-16870675 ] Wes McKinney commented on ARROW-5691: - Well, the symbols have to go into some shared library, so pick

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-06-23 Thread Uwe L. Korn (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870498#comment-16870498 ] Uwe L. Korn commented on ARROW-5691: I would be 100% fine with moving it into {{src/arrow/parquet}}

[jira] [Commented] (ARROW-5691) [C++] Relocate src/parquet/arrow code to src/arrow/dataset/parquet

2019-06-22 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-5691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870356#comment-16870356 ] Wes McKinney commented on ARROW-5691: - cc [~xhochy] if you have thoughts > [C++] Relocate