[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-31 Thread Neal Richardson (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897267#comment-16897267 ] Neal Richardson commented on ARROW-6004: This patch does not change the default, only correctly

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-31 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897264#comment-16897264 ] Francois Saint-Jacques commented on ARROW-6004: --- I was agreeing with the (current) default

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-31 Thread Neal Richardson (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897263#comment-16897263 ] Neal Richardson commented on ARROW-6004: It's an option many (most? all?) of the other common CSV

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-31 Thread Joris Van den Bossche (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897257#comment-16897257 ] Joris Van den Bossche commented on ARROW-6004: -- [~fsaintjacques] skipping empty lines is

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-31 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897238#comment-16897238 ] Francois Saint-Jacques commented on ARROW-6004: --- I'd expect the empty lines to be skipped,

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-23 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891078#comment-16891078 ] Antoine Pitrou commented on ARROW-6004: --- Pandas does this: {code:python} >>>

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891011#comment-16891011 ] Wes McKinney commented on ARROW-6004: - Hm, I am not sure about this. What do other CSV readers do

[jira] [Commented] (ARROW-6004) [C++] CSV reader ignore_empty_lines option doesn't handle empty lines

2019-07-23 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890923#comment-16890923 ] Antoine Pitrou commented on ARROW-6004: --- > Correct behavior should be to fill those empty lines