Pindikura Ravindra created ARROW-3487: -----------------------------------------
Summary: simplify NULL_IF_NULL functions that can return errors Key: ARROW-3487 URL: https://issues.apache.org/jira/browse/ARROW-3487 Project: Apache Arrow Issue Type: Task Components: Gandiva Reporter: Pindikura Ravindra NULL_IF_NULL functions that can return errors eg. divide currently look at the validity bits in each function (to avoid returning spurious errors). {code:java} divide(TYPE in1, boolean is_valid1, TYPE in2, boolean is_valid2, ..) { if (!is_valid1 || !is_valid2) { return 0; } if (in2 == 0) { /* set error */ } } {code} This validity check is duplicated for multiple functions and should be moved to the common layer (for all NULL_IF_NULL functions that can return error). -- This message was sent by Atlassian JIRA (v7.6.3#76005)