[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946252#comment-16946252 ] sridhar Reddy commented on BEAM-7049: - Thank you for the update.  re: Infinite Loop. I encountered

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943253#comment-16943253 ] sridhar Reddy edited comment on BEAM-7049 at 10/3/19 12:07 AM: --- Sounds good.

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943253#comment-16943253 ] sridhar Reddy commented on BEAM-7049: - Sounds good. Take your time. I appreciate you helping people on

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941410#comment-16941410 ] sridhar Reddy commented on BEAM-7049: - [~amaliujia] I just want to make sure that we are on the same

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933828#comment-16933828 ] sridhar Reddy commented on BEAM-7049: - I reviewed the PR and related JIRA. I see what you are saying.

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933048#comment-16933048 ] sridhar Reddy commented on BEAM-7049: - I agree with your assessment.  > Merge multiple input to one

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933042#comment-16933042 ] sridhar Reddy commented on BEAM-7049: - [~amaliujia] I tried the tests you suggested and have noted the

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933041#comment-16933041 ] sridhar Reddy commented on BEAM-7049: - I did the tests with the following steps # re-clone a new repo

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932032#comment-16932032 ] sridhar Reddy edited comment on BEAM-7049 at 9/18/19 4:12 AM: -- I noticed

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932032#comment-16932032 ] sridhar Reddy edited comment on BEAM-7049 at 9/18/19 4:11 AM: -- I noticed

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932032#comment-16932032 ] sridhar Reddy edited comment on BEAM-7049 at 9/18/19 4:10 AM: -- I noticed

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932032#comment-16932032 ] sridhar Reddy commented on BEAM-7049: - I noticed there is a change in behavior between union vs union

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929541#comment-16929541 ] sridhar Reddy commented on BEAM-7049: - I believe all the code that is required for this feature to

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929500#comment-16929500 ] sridhar Reddy commented on BEAM-7049: - With the change in location of UnionMergeRule.INSTANCE it is

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929478#comment-16929478 ] sridhar Reddy commented on BEAM-7049: - My WIP pull request (#9358 )already contains code to handle

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929474#comment-16929474 ] sridhar Reddy commented on BEAM-7049: - My inputs here are 2

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929466#comment-16929466 ] sridhar Reddy commented on BEAM-7049: - For the query "SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928956#comment-16928956 ] sridhar Reddy commented on BEAM-7049: - Sounds good! > Merge multiple input to one BeamUnionRel >

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921535#comment-16921535 ] sridhar Reddy edited comment on BEAM-7049 at 9/3/19 4:21 PM: - Hope you had a

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921535#comment-16921535 ] sridhar Reddy commented on BEAM-7049: - Hope you had a nice vacation! I will be on vacation myself from

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919139#comment-16919139 ] sridhar Reddy edited comment on BEAM-7049 at 8/30/19 3:00 AM: -- After several

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919139#comment-16919139 ] sridhar Reddy commented on BEAM-7049: - After several attempts to generalize union with multiple

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913442#comment-16913442 ] sridhar Reddy commented on BEAM-7049: - Thanks for the quick update. I agree that it is helpful to have

[jira] [Comment Edited] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912882#comment-16912882 ] sridhar Reddy edited comment on BEAM-7049 at 8/22/19 3:35 AM: -- Just including

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912882#comment-16912882 ] sridhar Reddy commented on BEAM-7049: - Just including UnionMergeRule.INSTANCE in BeamRuleSets makes

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908680#comment-16908680 ] sridhar Reddy commented on BEAM-7049: - Here is the pull request. As I mentioned in the description the

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907689#comment-16907689 ] sridhar Reddy commented on BEAM-7049: - Good idea! I will create one > Merge multiple input to one

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906734#comment-16906734 ] sridhar Reddy commented on BEAM-7049: - Made a couple of simple cases work  1)select 1 from

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905695#comment-16905695 ] sridhar Reddy commented on BEAM-7049: - Made great progress in understanding the code but still working

[jira] [Commented] (BEAM-7049) Merge multiple input to one BeamUnionRel

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903422#comment-16903422 ] sridhar Reddy commented on BEAM-7049: - [~amaliujia] Thanks for the update. I think I understand the

[jira] [Commented] (BEAM-7049) BeamUnionRel should work on mutiple input

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902548#comment-16902548 ] sridhar Reddy commented on BEAM-7049: - [~amaliujia] Thanks for checking in with me.    I just

[jira] [Commented] (BEAM-7049) BeamUnionRel should work on mutiple input

[ https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899194#comment-16899194 ] sridhar Reddy commented on BEAM-7049: - [~amaliujia] Thanks for the update. I will start working on

[jira] [Resolved] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sridhar Reddy resolved BEAM-7724. - Resolution: Won't Fix Fix Version/s: Not applicable Ideally, this issue should be

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899162#comment-16899162 ] sridhar Reddy commented on BEAM-7724: - As per the above discussion, I will be closing this issue. >

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898388#comment-16898388 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia] Can you please clarify the code you are referring

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897502#comment-16897502 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia] After debugging the issue I believe there is

[jira] [Comment Edited] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891266#comment-16891266 ] sridhar Reddy edited comment on BEAM-7724 at 7/31/19 8:08 PM: -- [~amaliujia] I

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896485#comment-16896485 ] sridhar Reddy commented on BEAM-7724: - Recreated the issue with a simple test program and janino

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893219#comment-16893219 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia]  Thank you for summarising the code generation in

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892301#comment-16892301 ] sridhar Reddy commented on BEAM-7724: - I was able to reproduce the problem. Looking into implementing

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891266#comment-16891266 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia] I tested this issue a little bit and found out