[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-08-02 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899162#comment-16899162 ] sridhar Reddy commented on BEAM-7724: - As per the above discussion, I will be closing this issue. >

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-08-01 Thread Rui Wang (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898550#comment-16898550 ] Rui Wang commented on BEAM-7724: [~sridharG] I think you are right. The link I posted covers the case

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-08-01 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898388#comment-16898388 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia] Can you please clarify the code you are referring

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-31 Thread Rui Wang (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897509#comment-16897509 ] Rui Wang commented on BEAM-7724: Thanks Sridhar. Could you verify if we could add one extra step to

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-31 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897502#comment-16897502 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia] After debugging the issue I believe there is

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-30 Thread Rui Wang (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896505#comment-16896505 ] Rui Wang commented on BEAM-7724: Thanks! This is a great verification! > Codegen should cast(null) to a

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-30 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896485#comment-16896485 ] sridhar Reddy commented on BEAM-7724: - Recreated the issue with a simple test program and janino

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-25 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893219#comment-16893219 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia]  Thank you for summarising the code generation in

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-25 Thread Rui Wang (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892967#comment-16892967 ] Rui Wang commented on BEAM-7724: [~sridharG] Note that it is likely that the change might not happen

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-25 Thread Rui Wang (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892960#comment-16892960 ] Rui Wang commented on BEAM-7724: A little more background about code generation in BeamSQL: The code

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-24 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892301#comment-16892301 ] sridhar Reddy commented on BEAM-7724: - I was able to reproduce the problem. Looking into implementing

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-23 Thread Rui Wang (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891330#comment-16891330 ] Rui Wang commented on BEAM-7724: I remember the code path you used had an issue that if you define two

[jira] [Commented] (BEAM-7724) Codegen should cast(null) to a type to match exact function signature

2019-07-23 Thread sridhar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891266#comment-16891266 ] sridhar Reddy commented on BEAM-7724: - [~amaliujia] I tested this issue a little bit and found out