[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067927#comment-17067927 ] Maximilian Michels commented on BEAM-9566: -- I'm backporting the two fixes in

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067883#comment-17067883 ] Bingfeng Xia commented on BEAM-9566: Yes! The same performance as before now. Glad to see that! >

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067821#comment-17067821 ] Maximilian Michels commented on BEAM-9566: -- Great, looks like we have the same performance as

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067807#comment-17067807 ] Bingfeng Xia commented on BEAM-9566: Thanks [~mxm] I re-run the test with your patch, and got the

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067800#comment-17067800 ] Maximilian Michels commented on BEAM-9566: -- Here you go:

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067795#comment-17067795 ] Bingfeng Xia commented on BEAM-9566: Can you point me to your New Caching Layer PR? Thanks [~mxm] >

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067704#comment-17067704 ] Maximilian Michels commented on BEAM-9566: -- Thank you [~Bingfeng Xia] for testing. The reason you

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067356#comment-17067356 ] Bingfeng Xia commented on BEAM-9566: Thanks for the quick fix [~mxm].  I have patched your #11200 to

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066092#comment-17066092 ] Maximilian Michels commented on BEAM-9566: -- With the changes in BEAM-9573 the impact might be

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065313#comment-17065313 ] Bingfeng Xia commented on BEAM-9566: Thanks for confirm this issue [~mxm] [~iemejia], I just followed

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065106#comment-17065106 ] Maximilian Michels commented on BEAM-9566: -- I've answered these in BEAM-9573. Thank you for your

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065012#comment-17065012 ] Rui Wang commented on BEAM-9566: [~mxm] RC0 is being built already. Could you move this JIRA to 2.21.0?

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064877#comment-17064877 ] Maximilian Michels commented on BEAM-9566: -- Very likely, Flink 1.10 is a batch-centered release:

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064847#comment-17064847 ] Ismaël Mejía commented on BEAM-9566: Is the batch improvement due to upsream 1.10 batch improvements?

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064831#comment-17064831 ] Maximilian Michels commented on BEAM-9566: -- The mentioned regression code path in the Flink

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064791#comment-17064791 ] Ismaël Mejía commented on BEAM-9566: [~Bingfeng Xia] mind to share the exact CLI you run into to

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064790#comment-17064790 ] Ismaël Mejía commented on BEAM-9566: Just for ref I created a view of the Nexmark runs in the CI to

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064667#comment-17064667 ] Maximilian Michels commented on BEAM-9566: -- Thank you for reporting. I'm marking this as a

[jira] [Commented] (BEAM-9566) Performance regression of FlinkRunner stream mode due to watermark holds update

[ https://issues.apache.org/jira/browse/BEAM-9566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064663#comment-17064663 ] Ismaël Mejía commented on BEAM-9566: Pinging [~reuvenlax] [~mxm] > Performance regression of