[GitHub] sijie commented on issue #1582: Enhancing DecommissionBookieCmd

sijie commented on issue #1582: Enhancing DecommissionBookieCmd URL: https://github.com/apache/bookkeeper/pull/1582#issuecomment-410409375 overall looks good. some minor comments on logging. This is an automated message from

[GitHub] sijie commented on a change in pull request #1582: Enhancing DecommissionBookieCmd

sijie commented on a change in pull request #1582: Enhancing DecommissionBookieCmd URL: https://github.com/apache/bookkeeper/pull/1582#discussion_r207694525 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @@ -2521,8 +2524,26

[GitHub] sijie commented on a change in pull request #1582: Enhancing DecommissionBookieCmd

sijie commented on a change in pull request #1582: Enhancing DecommissionBookieCmd URL: https://github.com/apache/bookkeeper/pull/1582#discussion_r207694497 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @@ -2490,25 +2490,28

[GitHub] sijie commented on a change in pull request #1582: Enhancing DecommissionBookieCmd

sijie commented on a change in pull request #1582: Enhancing DecommissionBookieCmd URL: https://github.com/apache/bookkeeper/pull/1582#discussion_r207694542 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @@ -2521,8 +2524,26

[GitHub] sijie commented on a change in pull request #1576: Record ctime for underreplicated ledger mark time.

sijie commented on a change in pull request #1576: Record ctime for underreplicated ledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576#discussion_r207694394 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerUnderreplicationManager.jav

[GitHub] sijie commented on a change in pull request #1576: Record ctime for underreplicated ledger mark time.

sijie commented on a change in pull request #1576: Record ctime for underreplicated ledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576#discussion_r207694335 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @

[GitHub] sijie commented on issue #1577: Metadata Update mechanism

sijie commented on issue #1577: Metadata Update mechanism URL: https://github.com/apache/bookkeeper/pull/1577#issuecomment-410408800 @eolivelli please hold on merging. I would like to get @athanatos or @jvrao to take a look at this first. because they are looking into similar things recent

[GitHub] sijie commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

sijie commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#issuecomment-410408684 > One thing to note is that this will trigger more load on zookeeper. For example, with Pulsar, you may have 100,000

[GitHub] jvrao commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

jvrao commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#issuecomment-410406927 retest please This is an automated message from the

[GitHub] reddycharan edited a comment on issue #1576: Record ctime for underreplicated ledger mark time.

reddycharan edited a comment on issue #1576: Record ctime for underreplicated ledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576#issuecomment-410335601 @jvrao @athanatos @dlg99 can you take a look This is

[GitHub] reddycharan commented on issue #1582: Enhancing DecommissionBookieCmd

reddycharan commented on issue #1582: Enhancing DecommissionBookieCmd URL: https://github.com/apache/bookkeeper/pull/1582#issuecomment-410335837 @jvrao @dlg99 can you take a look This is an automated message from the Apache Gi

[GitHub] reddycharan commented on issue #1576: Record ctime for underreplicated ledger mark time.

reddycharan commented on issue #1576: Record ctime for underreplicated ledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576#issuecomment-410335601 @jvrao @athanatos can you take a look This is an automated me

Jenkins build became unstable: bookkeeper_codecoverage #166

See

[GitHub] reddycharan opened a new pull request #1582: Enhancing DecommissionBookieCmd

reddycharan opened a new pull request #1582: Enhancing DecommissionBookieCmd URL: https://github.com/apache/bookkeeper/pull/1582 Descriptions of the changes in this PR: - adding bookieid option to DecommissionBookieCmd, to enable decommissioning remote bookie. This might be ne

[GitHub] jvrao edited a comment on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

jvrao edited a comment on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#issuecomment-410310535 > Anyhow, a philosophical point, and unrelated to whether this change is good. You are absolutely righ

[GitHub] jvrao commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

jvrao commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#issuecomment-410310535 > Anyhow, a philosophical point, and unrelated to whether this change is good. You are absolutely right. I will c

[GitHub] eolivelli commented on issue #1581: Add Code Coverage report for 'Stream' modules

eolivelli commented on issue #1581: Add Code Coverage report for 'Stream' modules URL: https://github.com/apache/bookkeeper/issues/1581#issuecomment-410289907 @sijie thank you new run https://builds.apache.org/job/bookkeeper_codecoverage/166/

Jenkins build became unstable: bookkeeper_release_branch_47_java9 #117

See

[GitHub] sijie commented on issue #1581: Add Code Coverage report for 'Stream' modules

sijie commented on issue #1581: Add Code Coverage report for 'Stream' modules URL: https://github.com/apache/bookkeeper/issues/1581#issuecomment-410282798 @eolivelli : https://github.com/apache/bookkeeper/blob/master/.test-infra/jenkins/job_bookkeeper_postcommit_master_java8.groovy#L42 -

Jenkins build became unstable: bookkeeper_release_branch_46 #115

See

Build failed in Jenkins: bookkeeper_release_nightly_snapshot #84

See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H33 (ubuntu xenial) in workspace

Build failed in Jenkins: bookkeeper_release_branch_47_integrationtests #105

See -- [...truncated 10.43 KB...] root 304 2 0 Jul 25 0.0 0.0 [kworker/7:1H] root 476 2 0 Jul 25 0.0 0.0 [ext4-rsv-conver]

[GitHub] eolivelli commented on issue #1581: Add Code Coverage report for 'Stream' modules

eolivelli commented on issue #1581: Add Code Coverage report for 'Stream' modules URL: https://github.com/apache/bookkeeper/issues/1581#issuecomment-410217295 cc @sijie This is an automated message from the Apache Git Servic

[GitHub] eolivelli opened a new issue #1581: Add Code Coverage report for 'Stream' modules

eolivelli opened a new issue #1581: Add Code Coverage report for 'Stream' modules URL: https://github.com/apache/bookkeeper/issues/1581 In order to enable code coverage reporting on Stream modules we have to add -DstreamTests to the command line of the Jenkins build I have started a

[GitHub] ivankelly commented on a change in pull request #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

ivankelly commented on a change in pull request #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#discussion_r207493844 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandl

[GitHub] ivankelly commented on a change in pull request #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

ivankelly commented on a change in pull request #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#discussion_r207494923 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWrite

[GitHub] eolivelli commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

eolivelli commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#issuecomment-410189520 @jvrao there are also compilation errors, maybe it is just enough to rebase to current master 2018-08-03

[GitHub] eolivelli commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes

eolivelli commented on issue #1580: (@bug W-5100764@) Write Ledger Handle listens for metadata changes URL: https://github.com/apache/bookkeeper/pull/1580#issuecomment-410189196 @jvrao there are checkstyle issues, we must fix them before merging to master 2018-08-03T04:37:29.104 [INF

[GitHub] eolivelli commented on a change in pull request #1577: Metadata Update mechanism

eolivelli commented on a change in pull request #1577: Metadata Update mechanism URL: https://github.com/apache/bookkeeper/pull/1577#discussion_r207473806 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MetadataUpdateLoop.java ## @@ -0,0 +1,186 @

[GitHub] merlimat commented on issue #1578: Auditor run Periodic check only once

merlimat commented on issue #1578: Auditor run Periodic check only once URL: https://github.com/apache/bookkeeper/issues/1578#issuecomment-410174320 There is a dead-lock in ZK thread. ``` "main-EventThread" #11 daemon prio=5 os_prio=0 tid=0x7f05385d3aa0 nid=0x5bd2 waiting on c

[GitHub] ivankelly commented on a change in pull request #1577: Metadata Update mechanism

ivankelly commented on a change in pull request #1577: Metadata Update mechanism URL: https://github.com/apache/bookkeeper/pull/1577#discussion_r207459509 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MetadataUpdateLoop.java ## @@ -0,0 +1,186 @