[GitHub] eolivelli commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

eolivelli commented on a change in pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802#discussion_r232444573 ## File path:

[GitHub] reddycharan opened a new pull request #1803: Fix indentation in BP-34 doc

reddycharan opened a new pull request #1803: Fix indentation in BP-34 doc URL: https://github.com/apache/bookkeeper/pull/1803 Descriptions of the changes in this PR: - just indentation fix This is an

[GitHub] sijie opened a new pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791

sijie opened a new pull request #1802: [branch 4.8] Fix compilation issue introduced by issue #1791 URL: https://github.com/apache/bookkeeper/pull/1802 Descriptions of the changes in this PR: *Motivation* when #1791 is cherry-picked into branch-4.8, it breaks the

[GitHub] sijie closed issue #1750: web site of bookkeeper

sijie closed issue #1750: web site of bookkeeper URL: https://github.com/apache/bookkeeper/issues/1750 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] sijie commented on issue #1756: [Question] metadataServiceUri with multiple zk servers

sijie commented on issue #1756: [Question] metadataServiceUri with multiple zk servers URL: https://github.com/apache/bookkeeper/issues/1756#issuecomment-437543829 @hiscal2015 I am closing this issue since the question is answered. If you still see the issue, please reopen it.

[GitHub] sijie closed issue #1756: [Question] metadataServiceUri with multiple zk servers

sijie closed issue #1756: [Question] metadataServiceUri with multiple zk servers URL: https://github.com/apache/bookkeeper/issues/1756 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #1761: Document issue

sijie commented on issue #1761: Document issue URL: https://github.com/apache/bookkeeper/issues/1761#issuecomment-437543748 the doc page will be updated (fixed) by #1800 This is an automated message from the Apache Git

[GitHub] sijie opened a new pull request #1801: [build] Ignore `versionsBackup` file generated by `mvn versions:set`

sijie opened a new pull request #1801: [build] Ignore `versionsBackup` file generated by `mvn versions:set` URL: https://github.com/apache/bookkeeper/pull/1801 Descriptions of the changes in this PR: *Motivation* `mvn versions:set` will generate files suffixed with

[GitHub] sijie opened a new pull request #1800: Issue 1799: bkctl is broken with default build options

sijie opened a new pull request #1800: Issue 1799: bkctl is broken with default build options URL: https://github.com/apache/bookkeeper/pull/1800 Descriptions of the changes in this PR: *Motivation* `bkctl` is designed in a modularized way for extensibility. it loads

[GitHub] merlimat commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232432569 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ##

[GitHub] sijie closed pull request #1793: [tools] improve bkctl help message

sijie closed pull request #1793: [tools] improve bkctl help message URL: https://github.com/apache/bookkeeper/pull/1793 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #1671: remove misleading comment

sijie commented on issue #1671: remove misleading comment URL: https://github.com/apache/bookkeeper/pull/1671#issuecomment-437536833 ping @ivankelly This is an automated message from the Apache Git Service. To respond to the

[GitHub] reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437536329 ok. lgtm. This is an automated message from the

[GitHub] sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437534159 > so they would be able to run only commands in 'cluster'/'ledger' group but not in 'bookie' (commands which access

[GitHub] reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437532130 @sijie thanks for explanation. Yes, I was little confused about purpose of this package. When you say "At

[GitHub] sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437523268 @reddycharan updated the description. And if you have reviewed the PR, the package is not called ‘tools’, it is

[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools

eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232418458 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ##

[GitHub] sijie commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#discussion_r232415348 ## File path: bookkeeper-dist/src/assemble/bkctl.xml ## @@ -0,0 +1,116 @@

[GitHub] reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437515038 @sijie i feel word 'tools' is kind of misleading. It kind of gives impression that it just contains tools to

[GitHub] reddycharan commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution

reddycharan commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#discussion_r232411425 ## File path: bookkeeper-dist/src/assemble/bkctl.xml ## @@ -0,0 +1,116 @@

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-437513582 @eolivelli PTAL again This is an automated message from the

[GitHub] sijie commented on issue #1793: [tools] improve bkctl help message

sijie commented on issue #1793: [tools] improve bkctl help message URL: https://github.com/apache/bookkeeper/pull/1793#issuecomment-437508513 run bookkeeper-server replication tests This is an automated message from the

[GitHub] sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437498796 @reddycharan I am not moving anything. I am creating a new binary distribution that only includes tools. People can

[GitHub] reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

reddycharan commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437497286 Hey @sijie whats the purpose of this change? what are you moving and how would it help?

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-437473063 run pr validation This is an automated message from

[GitHub] merlimat edited a comment on issue #1641: Added module to enable CPU affinity

merlimat edited a comment on issue #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#issuecomment-437434099 > Do you have some preliminary numbers then to show why this change is valuable? @ivankelly This are the numbers on my

[GitHub] merlimat commented on issue #1641: Added module to enable CPU affinity

merlimat commented on issue #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#issuecomment-437464240 run pr validation This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-437461941 run pr validation This is an automated message from the Apache

[GitHub] merlimat commented on issue #1641: Added module to enable CPU affinity

merlimat commented on issue #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#issuecomment-437434099 > Do you have some preliminary numbers then to show why this change is valuable? @ivankelly This are the numbers on my local

[GitHub] sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437433540 run pr validation This is an automated message from

[GitHub] ivankelly opened a new issue #1799: bkctl is broken with default build options

ivankelly opened a new issue #1799: bkctl is broken with default build options URL: https://github.com/apache/bookkeeper/issues/1799 When building without the -Dstream profile enabled, the bkctl command is broken. ``` 2018-11-09 16:18:43,271 - ERROR - [main:DockerUtils@188] -

Jenkins build became unstable: bookkeeper_codecoverage #264

See

Jenkins build is still unstable: bookkeeper_release_branch_46 #211

See

Build failed in Jenkins: bookkeeper_release_branch_48_java8 #86

See Changes: [sijie] Cache InetSocketAddress if hostname is IPAddress [sijie] Issue #1791: Read Submission should bypass OSE Threads [sijie] [TOOLS] add cookie related commands

Build failed in Jenkins: bookkeeper_release_nightly_snapshot #189

See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H33 (ubuntu xenial) in workspace

Build failed in Jenkins: bookkeeper_release_branch_47_integrationtests #201

See Changes: [sijie] Cache InetSocketAddress if hostname is IPAddress -- [...truncated 11.07 KB...] root 727 1 726 Jul 25 0.0

Build failed in Jenkins: bookkeeper_postcommit_master_python #31

See Changes: [guosijie] Cache InetSocketAddress if hostname is IPAddress [guosijie] Issue #1791: Read Submission should bypass OSE Threads [github] [TOOLS] add cookie related commands

[GitHub] ivankelly commented on issue #1641: Added module to enable CPU affinity

ivankelly commented on issue #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#issuecomment-437344780 > > However, I think we need an overarching document for these "performance" improvements, with benchmark results, detailed instructions to

Build failed in Jenkins: bookkeeper_release_branch_48_java9 #86

See Changes: [sijie] Cache InetSocketAddress if hostname is IPAddress [sijie] Issue #1791: Read Submission should bypass OSE Threads [sijie] [TOOLS] add cookie related commands

[GitHub] ivankelly commented on issue #1797: Move version out of LedgerMetadata

ivankelly commented on issue #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797#issuecomment-437303033 rerun pr validation rerun bookkeeper-server client tests This is an

[GitHub] sijie commented on issue #1786: BP-36: Stats documentation annotation

sijie commented on issue #1786: BP-36: Stats documentation annotation URL: https://github.com/apache/bookkeeper/pull/1786#issuecomment-437280682 run pr validation This is an automated message from the Apache Git Service. To