[GitHub] [bookkeeper] lhotari commented on pull request #3110: PendingReadOp: Fix ledgerEntryImpl reuse problem

2022-03-16 Thread GitBox
lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1068857090 > https://github.com/apache/bookkeeper/blob/e99cd4915b56ae3e9891ef9a83eb5e8f089505d7/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java#L146

[GitHub] [bookkeeper] lhotari commented on pull request #3110: PendingReadOp: Fix ledgerEntryImpl reuse problem

2022-03-15 Thread GitBox
lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1068136249 I now see the reason why Congbo chose to implement it using ```java public void close() { complete.set(true); entryImpl.close();

[GitHub] [bookkeeper] lhotari commented on pull request #3110: PendingReadOp: Fix ledgerEntryImpl reuse problem

2022-03-15 Thread GitBox
lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1068099040 Thanks for the explanation @hangc0276 . I now understood how the race condition happens in `org.apache.bookkeeper.client.PendingReadOp#readEntryComplete` method and it