eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-397652776
rerun bookkeeper-server bookie tests
This is an automated message
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-397637455
rerun bookkeeper-server bookie tests
This is an automated message
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-397612674
rerun bookkeeper-server bookie tests
This is an automated message
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-397552150
rerun bookkeeper-server bookie tests
This is an automated message
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-397527391
@jvrao @sijie @jiazhai
Thank you !
I have rebased to latest master, I will wait for CI to pass and then merge.
This
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396881301
@sijie @jvrao FYI I have added a commit to drop 'error out pending adds" in
case of failure in force operation.
So we are
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396571250
I meant @jvrao suggested to error our pending adds.
I think we do not need to do so.
I will remove that from the patch,
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396482039
@sijie in the fsync / force metaphor I think it is better not to fail
pending adds.
It was a comment/request from @jvrao.
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396160571
@sijie @jvrao
waiting for your comments and hopefully approval.
I have found an edge case, but I don't know if it is
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-395124763
@jvrao @sijie
All of your comments addressed. Now it looks really better ! Thank you
Additional implementation to note:
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-394740832
retest this please
This is an automated message from the Apache
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-393634809
@jvrao @jiazhai please take a new look as you have cycles.
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-393094971
@sijie
In the limited scope of this PR I think that it is good that we are not
breaking ExplicitLAC and it is working as
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-393079231
@sijie
I agree at 100% with your higher level description. I would like to have
such "background flush" .
I am looking
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392909847
@sijie your point is very interesting.
Let me think about it a bit more.
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392801953
@sijie I have added a test case about using ExplicitLAC and DEFERRED_SYNC.
I think that current behaviour is what I am
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392798320
@jiazhai @jvrao I have addressed all of your comments and provided answers.
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392650536
@sijie explicitlac for deferred sync writers only sends the value of
LastAddConfirmed and it is still a way to notify LAC changes
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392555446
retest this please
This is an automated message from the Apache
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392429868
retest this please
This is an automated message from the Apache
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-391756742
This is still WIP but almost complete, missing items:
- prevent v2 clients to use force() API
- add test cases for corner
eolivelli commented on issue #1436: BP-14 force() API - client side
implementation
URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-392336831
@jvrao @sijie the patch is ready for review now
This is an
22 matches
Mail list logo
