ivankelly commented on issue #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#issuecomment-346503785 +1 On Wed 22 Nov 2017, 23:48 Sijie Guo <notificati...@github.com> wrote: > *@sijie* commented on this pull request. > ------------------------------ > > In > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteHandle.java > <https://github.com/apache/bookkeeper/pull/755#discussion_r152702805>: > > > @@ -41,7 +41,8 @@ > /** > * Add entry asynchronously to an open ledger. > * > - * @param data array of bytes to be written > + * @param data a bytebuf to be written. The bytebuf's reference count will be decremented by 1 after the > > okay I will change it to "when the returned completablefuture is completed" > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/bookkeeper/pull/755#discussion_r152702805>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AADWq39RxV3o1bkovXvYesq0nLBE1Pk5ks5s5LLCgaJpZM4Qm0d6> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
