[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-20 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r152178441 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-17 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151622402 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-17 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151622402 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-17 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151622430 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-16 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151592290 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCounter.java

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-16 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151588012 ## File path:

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-16 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151587614 ## File path:

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-16 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151585699 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-16 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151584415 ## File path:

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-16 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r151462675 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCounter.java