[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-23 Thread GitBox
jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346598103 seems, it is not able to merge with merge script, it reported: ``` bookkeeper git:(master) ? python

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346308299 @ivankelly @sijie updated. This is an automated message

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346301408 @ivan, Thanks for the comments, the reason is described in the issue, will move it here.

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346249325 Rebased master, since the LedgerEntry changes. @sijie @eolivelli Would you please help check this again.

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-15 Thread GitBox
jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-344606742 @eolivelli, Regarding the release/retain story, Here is the understanding: Before this change, read() return result