[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

2017-11-23 Thread GitBox
jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346614792 the first issue, looks like a bug of github? seems all the state in

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

2017-11-23 Thread GitBox
jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346614792 the first issue, looks like a bug of github? seems all the state in

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

2017-11-23 Thread GitBox
jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346609009 not sure what is the error, according the the example pr_reviews, reviewers_ids should be added, ``` [

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

2017-11-23 Thread GitBox
jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346605849 this part of code not get the right list, ``` approval_review_states = ['approved'] pr_reviews =

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

2017-11-23 Thread GitBox
jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346605849 seems related with github api changes? this part of code not get the right list, ```