sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375821309
retest this please
This is an automated message from the Apache Git Service.
To respond
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375770793
> If we were using stock ConcurrentHashMap it'd be less risky, but since the
hashmap is our code too, it's better to err on the safe side.
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375752857
@ivankelly
> it seems pointless to have locks around a concurrent hashmap
well. depends on how you see stuffs. concurrent hashmap is section
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375587424
> Ah yes. At minimum we should be checking again for existence inside the
write lock.
this is one of the change I made here, checking the
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375587424
> Ah yes. At minimum we should be checking again for existence inside the
write lock.
this is one of the change I made here, checking the
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639
> Could you give a sequence of events for how the other race occurs?
I am using your diagram and using the existing logic
```
| Read Fi
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639
> Could you give a sequence of events for how the other race occurs?
I am using your diagram and using the existing logic
```
| Read Fi
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639
> Could you give a sequence of events for how the other race occurs?
I am using your diagram and using the existing logic
```
| Read Fi
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639
> Could you give a sequence of events for how the other race occurs?
I am using your diagram and using the existing logic
```
| Read Fi
sijie commented on issue #1284: Improve FileInfoBackingCache
URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639
> Could you give a sequence of events for how the other race occurs?
I am using your diagram and using the existing logic
```
| Read Fi
10 matches
Mail list logo
