[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347620519 @ivankelly `CompletableFuture methodAsync()` is better if you are going to provide a sync version of same method `void method()`.

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347363435 it seems that the return type is still `CompletableFuture`? This is an

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347055799 you can use `FutureUtils.complete(future, null)`. I would prefer using `CompletableFuture` for doing nothing. because this is a pattern that

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-346888391 your change doesn't seem to have a fundamentally difference from existing `readBookiesBlocking` logic. `readBookiesBlocking` is a blocking