Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #114

See

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153020549 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java ## @@

[GitHub] sijie commented on a change in pull request #772: bookkeeper script excludes sources jar

sijie commented on a change in pull request #772: bookkeeper script excludes sources jar URL: https://github.com/apache/bookkeeper/pull/772#discussion_r153074715 ## File path: bookkeeper-server/bin/bookkeeper ## @@ -71,18 +71,18 @@ else fi # exclude tests jar

[GitHub] sijie commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

sijie commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153075079 ## File path:

[GitHub] sijie commented on issue #773: Shade bookkeeper-common into bookkeeper-server

sijie commented on issue #773: Shade bookkeeper-common into bookkeeper-server URL: https://github.com/apache/bookkeeper/pull/773#issuecomment-347019363 I think you encountered this issue because of #772, which you might take `shaded` jar into your classpath. but in general, this change

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153074975 ## File path: site/community/release_guide.md ## @@ -234,21 +244,14 @@ Use Maven release plugin to

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153075016 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have been

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153074990 ## File path: site/community/release_guide.md ## @@ -378,10 +381,10 @@ Start the review-and-vote

[GitHub] sijie commented on issue #771: Don't require password to create or open ledgers

sijie commented on issue #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#issuecomment-347018871 @ivankelly > if we do get rid of password, the first thing we'll need to do is to get people to stop using it explicitly in

[GitHub] sijie commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

sijie commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153075079 ## File path:

[GitHub] sijie commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#issuecomment-347018493 ping @jvrao This is an automated message from the Apache Git

[GitHub] sijie closed pull request #770: Make LedgerEntries an Iterable

sijie closed pull request #770: Make LedgerEntries an Iterable URL: https://github.com/apache/bookkeeper/pull/770 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] sijie commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-347018433 @jvrao ping? This is an

[GitHub] eolivelli commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

eolivelli commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153075311 ## File path:

[GitHub] eolivelli commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

eolivelli commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153075309 ## File path:

[GitHub] ivankelly commented on a change in pull request #772: bookkeeper script excludes sources jar

ivankelly commented on a change in pull request #772: bookkeeper script excludes sources jar URL: https://github.com/apache/bookkeeper/pull/772#discussion_r153082543 ## File path: bookkeeper-server/bin/bookkeeper ## @@ -71,18 +71,18 @@ else fi # exclude tests jar

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153082706 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java ## @@

[GitHub] ivankelly commented on issue #775: Tests wait for client to see started bookie

ivankelly commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347040409 I don't care about the type of the return, and I had originally. However, it's impossible to complete a CompletableFuture without

[GitHub] ivankelly commented on issue #775: Tests wait for client to see started bookie

ivankelly commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347040409 I don't care about the type of the return, and I had `` originally. However, it's impossible to complete a ```CompletableFuture```

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347041363 @eolivelli @jvrao Could we get some more opinions on this? In summary, we're discussing whether newOpenLedgerOp should default to doing recovery

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347055799 you can use `FutureUtils.complete(future, null)`. I would prefer using `CompletableFuture` for doing nothing. because this is a pattern that

[GitHub] sijie commented on issue #774: Open should run recovery by default

sijie commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347056937 the summary of my opinion on this : - from a storage system perspective, open should not have any implicit impacts on the current writer. if

[GitHub] sijie commented on issue #774: Open should run recovery by default

sijie commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347057001 @jvrao @jiazhai and other people are welcome to chime in. This is an automated

[GitHub] jiazhai commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

jiazhai commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#issuecomment-347060498 This is a great idea. A question in my mind is that, How it comes when a bookie is first slow, but

[GitHub] sijie commented on issue #771: Don't require password to create or open ledgers

sijie commented on issue #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#issuecomment-347100432 I would prefer deferring making this default until we have a plan to remove password. we don't have to rush this change in the api. you

[GitHub] eolivelli commented on issue #771: Don't require password to create or open ledgers

eolivelli commented on issue #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#issuecomment-347103084 As I have already said I am fine with keeping it required, without default. As I committed in the first version on the API

[GitHub] jvrao commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

jvrao commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#issuecomment-347091370 @sijie I will review if @reddycharan is not going to; I will ping him again tomorrow.

[GitHub] eolivelli commented on issue #771: Don't require password to create or open ledgers

eolivelli commented on issue #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#issuecomment-347097808 Ok for me to draw a roadmap towards dropping password. I think that having a default will let new applications and users be able

[GitHub] jvrao commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

jvrao commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-347092772 I made my comments; your changes look generally fine; if you believe you addressed comments its