[GitHub] jiazhai closed pull request #991: PendingReadOp: add counter for speculative reads

2018-01-17 Thread GitBox
jiazhai closed pull request #991: PendingReadOp: add counter for speculative reads URL: https://github.com/apache/bookkeeper/pull/991 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] eolivelli closed issue #981: SIGTERM on bookkeeper script not propagated to java process

2018-01-17 Thread GitBox
eolivelli closed issue #981: SIGTERM on bookkeeper script not propagated to java process URL: https://github.com/apache/bookkeeper/issues/981 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jiazhai closed issue #988: add more log lines to auditor for more info on autorecovery status changes

2018-01-17 Thread GitBox
jiazhai closed issue #988: add more log lines to auditor for more info on autorecovery status changes URL: https://github.com/apache/bookkeeper/issues/988 This is an automated message from the Apache Git Service. To respond

[GitHub] eolivelli closed pull request #994: Issue #981: Revert "ISSUE #561: Remove exec commands to start in the shell pid"

2018-01-17 Thread GitBox
eolivelli closed pull request #994: Issue #981: Revert "ISSUE #561: Remove exec commands to start in the shell pid" URL: https://github.com/apache/bookkeeper/pull/994 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] sschepens commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
sschepens commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996#discussion_r162058569 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DoubleByteBuf.java ## @@ -370,7

[GitHub] eolivelli commented on issue #990: Fix tight loop in getFileInfo

2018-01-17 Thread GitBox
eolivelli commented on issue #990: Fix tight loop in getFileInfo URL: https://github.com/apache/bookkeeper/pull/990#issuecomment-358331169 merging now on master and branch-4.6, thank you @ivankelly This is an automated

[GitHub] sschepens commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
sschepens commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996#discussion_r162059212 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DoubleByteBuf.java ## @@ -361,7

[GitHub] jiazhai closed pull request #977: LedgerHandle: add counters to track ledger->bookie counts

2018-01-17 Thread GitBox
jiazhai closed pull request #977: LedgerHandle: add counters to track ledger->bookie counts URL: https://github.com/apache/bookkeeper/pull/977 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sschepens commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
sschepens commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996#discussion_r162058569 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DoubleByteBuf.java ## @@ -370,7

[GitHub] eolivelli commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
eolivelli commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996#discussion_r162063453 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DoubleByteBuf.java ## @@ -370,7

[GitHub] eolivelli closed pull request #990: Fix tight loop in getFileInfo

2018-01-17 Thread GitBox
eolivelli closed pull request #990: Fix tight loop in getFileInfo URL: https://github.com/apache/bookkeeper/pull/990 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] jiazhai closed pull request #989: ISSUE #988: more log lines for replication status changes

2018-01-17 Thread GitBox
jiazhai closed pull request #989: ISSUE #988: more log lines for replication status changes URL: https://github.com/apache/bookkeeper/pull/989 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] athanatos commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets

2018-01-17 Thread GitBox
athanatos commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets URL: https://github.com/apache/bookkeeper/pull/993#discussion_r162139091 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

[GitHub] sijie commented on a change in pull request #965: BOOKKEEPER-933: Add support for PEM Key file formats

2018-01-17 Thread GitBox
sijie commented on a change in pull request #965: BOOKKEEPER-933: Add support for PEM Key file formats URL: https://github.com/apache/bookkeeper/pull/965#discussion_r162156185 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java

[GitHub] sijie commented on issue #980: Release notes for 4.6.1

2018-01-17 Thread GitBox
sijie commented on issue #980: Release notes for 4.6.1 URL: https://github.com/apache/bookkeeper/pull/980#issuecomment-358410034 @eolivelli I cherry-picked #996 into branch 4.6.1. can you update the release notes? This is an

[GitHub] athanatos opened a new pull request #997: ISSUE #985: Add log messages to indicate bucket levels of entryLog.

2018-01-17 Thread GitBox
athanatos opened a new pull request #997: ISSUE #985: Add log messages to indicate bucket levels of entryLog. URL: https://github.com/apache/bookkeeper/pull/997 (@bug W-413@) Signed-off-by: Venkateswararao Jujjuri (JV) [Fixed merge issues]

[GitHub] eolivelli commented on issue #980: Release notes for 4.6.1

2018-01-17 Thread GitBox
eolivelli commented on issue #980: Release notes for 4.6.1 URL: https://github.com/apache/bookkeeper/pull/980#issuecomment-358441977 Sure it is an important change This is an automated message from the Apache Git Service. To

[GitHub] sschepens opened a new pull request #998: revert DoubleByteBuf niobuffers() changes

2018-01-17 Thread GitBox
sschepens opened a new pull request #998: revert DoubleByteBuf niobuffers() changes URL: https://github.com/apache/bookkeeper/pull/998 Revert some of the changes in https://github.com/apache/bookkeeper/pull/996 since they cause issues

[GitHub] sijie commented on issue #998: revert DoubleByteBuf niobuffers() changes

2018-01-17 Thread GitBox
sijie commented on issue #998: revert DoubleByteBuf niobuffers() changes URL: https://github.com/apache/bookkeeper/pull/998#issuecomment-358445008 committers, please make sure this one is cherry-picked to 4.6. This is an

[GitHub] eolivelli commented on issue #998: revert DoubleByteBuf niobuffers() changes

2018-01-17 Thread GitBox
eolivelli commented on issue #998: revert DoubleByteBuf niobuffers() changes URL: https://github.com/apache/bookkeeper/pull/998#issuecomment-358446239 I will do, sure This is an automated message from the Apache Git Service.

[GitHub] sschepens commented on issue #980: Release notes for 4.6.1

2018-01-17 Thread GitBox
sschepens commented on issue #980: Release notes for 4.6.1 URL: https://github.com/apache/bookkeeper/pull/980#issuecomment-358442241 @sijie https://github.com/apache/bookkeeper/pull/996 included some changes that can cause errores, we've reverted them on pulsar, could you merge my new PR?

[GitHub] ivankelly opened a new issue #995: Remove asserts from code

2018-01-17 Thread GitBox
ivankelly opened a new issue #995: Remove asserts from code URL: https://github.com/apache/bookkeeper/issues/995 We currently assert in production code in a few places. These are disabled at runtime, and so have little value. We should replace these with thrown exceptions, or crash the

[GitHub] ivankelly commented on issue #990: Fix tight loop in getFileInfo

2018-01-17 Thread GitBox
ivankelly commented on issue #990: Fix tight loop in getFileInfo URL: https://github.com/apache/bookkeeper/pull/990#issuecomment-358249305 @sijie created #995 This is an automated message from the Apache Git Service. To

[GitHub] aahmed-se commented on issue #981: SIGTERM on bookkeeper script not propagated to java process

2018-01-17 Thread GitBox
aahmed-se commented on issue #981: SIGTERM on bookkeeper script not propagated to java process URL: https://github.com/apache/bookkeeper/issues/981#issuecomment-358240626 we have stable formulae for end users but problem encountered was here

[GitHub] ivankelly opened a new pull request #974: Utilities for working with Arquillian and Docker

2018-01-17 Thread GitBox
ivankelly opened a new pull request #974: Utilities for working with Arquillian and Docker URL: https://github.com/apache/bookkeeper/pull/974 This patch contains the following utilities. - An arquillian StopAction which copy logs from /var/log/bookkeeper to the target/ directory.

[GitHub] ivankelly closed pull request #974: Utilities for working with Arquillian and Docker

2018-01-17 Thread GitBox
ivankelly closed pull request #974: Utilities for working with Arquillian and Docker URL: https://github.com/apache/bookkeeper/pull/974 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ivankelly commented on issue #974: Utilities for working with Arquillian and Docker

2018-01-17 Thread GitBox
ivankelly commented on issue #974: Utilities for working with Arquillian and Docker URL: https://github.com/apache/bookkeeper/pull/974#issuecomment-358262479 retest this please This is an automated message from the Apache

[GitHub] ivankelly commented on issue #981: SIGTERM on bookkeeper script not propagated to java process

2018-01-17 Thread GitBox
ivankelly commented on issue #981: SIGTERM on bookkeeper script not propagated to java process URL: https://github.com/apache/bookkeeper/issues/981#issuecomment-358236070 Weird. I don't have a mac, so I can't try it out. In any case, I'm going to revert this change, as it's breaking

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162206786 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ## @@

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162204215 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ## @@

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162205255 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ## @@

[GitHub] reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162187774 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java ##

[GitHub] reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162187522 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ##

[GitHub] sijie commented on issue #999: Bookie Identifier / Bookie Port

2018-01-17 Thread GitBox
sijie commented on issue #999: Bookie Identifier / Bookie Port URL: https://github.com/apache/bookkeeper/issues/999#issuecomment-358456539 This needs a BP to raise a discussion. This is an automated message from the Apache

[GitHub] sijie opened a new issue #999: Bookie Identifier / Bookie Port

2018-01-17 Thread GitBox
sijie opened a new issue #999: Bookie Identifier / Bookie Port URL: https://github.com/apache/bookkeeper/issues/999 A general question coming up when running bookkeeper in a scheduler environment (e.g. mesos, aurora): can bookkeeper use dynamic port? Currently the port is used both as

[GitHub] sijie opened a new issue #1000: Break down bookie shell class

2018-01-17 Thread GitBox
sijie opened a new issue #1000: Break down bookie shell class URL: https://github.com/apache/bookkeeper/issues/1000 *Problem* `BookieShell` is becoming a gaint class to contain all the sub command. It is a good time to think about how to break this class down: - group the

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162203798 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ## @@

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162206461 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ## @@

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162205384 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ## @@

[GitHub] sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
sijie commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162208085 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperAdminTest.java ## @@ -230,4

[GitHub] reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162188038 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperAdminTest.java ## @@

[GitHub] reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
reddycharan commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162192649 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperAdminTest.java ## @@

[GitHub] athanatos commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd

2018-01-17 Thread GitBox
athanatos commented on a change in pull request #979: ISSUE #978: decouple metaformat cmd URL: https://github.com/apache/bookkeeper/pull/979#discussion_r162209800 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java ##

Jenkins build is still unstable: bookkeeper_release_branch #31

2018-01-17 Thread Apache Jenkins Server
See

Jenkins build is back to stable : bookkeeper_postcommit_master_java8 #11

2018-01-17 Thread Apache Jenkins Server
See

[GitHub] ArvinDevel opened a new issue #1007: Refactor checksum implementation: move it to protocol module

2018-01-17 Thread GitBox
ArvinDevel opened a new issue #1007: Refactor checksum implementation: move it to protocol module URL: https://github.com/apache/bookkeeper/issues/1007 **BP** This is the master ticket for tracking BP-<25>: Checksum semantic is more close to wire protocol compared to client,

[GitHub] ArvinDevel commented on issue #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper

2018-01-17 Thread GitBox
ArvinDevel commented on issue #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper URL: https://github.com/apache/bookkeeper/pull/1008#issuecomment-358556616 latest google doc:

[GitHub] ArvinDevel opened a new pull request #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper

2018-01-17 Thread GitBox
ArvinDevel opened a new pull request #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper URL: https://github.com/apache/bookkeeper/pull/1008 Descriptions of the changes in this PR: Current the checksum implementation is in client module while the checksum

[GitHub] eolivelli opened a new issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli opened a new issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? ``` git checkout branch-46 # now we are at

[GitHub] sijie commented on issue #975: Maven classloader

2018-01-17 Thread GitBox
sijie commented on issue #975: Maven classloader URL: https://github.com/apache/bookkeeper/pull/975#issuecomment-358499908 @ivankelly I try to resolve conflicts from PR, so CI can kick in and test this. but it doesn't seem to work. can you rebase this? so we can move this forward.

[GitHub] eolivelli opened a new issue #1001: DoubleByteBufferTest fails on branch-4.6

2018-01-17 Thread GitBox
eolivelli opened a new issue #1001: DoubleByteBufferTest fails on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1001 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run this command on branch-4.6 mvn test

[GitHub] eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003#issuecomment-358533859 odd fact: if I run the tests inside this directory, all runs fine bookkeeper/tests/backward I think it is due to

[GitHub] eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003#issuecomment-358533859 odd fact: if I run the tests inside this directory, all runs fine bookkeeper/tests/backward I think it is due to

[GitHub] eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003#issuecomment-358534567 if I run `mvn clean install` the problems does not occur on backward tests, so it is not a show stopper for release.

[GitHub] eolivelli opened a new issue #1004: Client of BookKeeper 4.6.1 imports dependencies to netty-common and netty-all

2018-01-17 Thread GitBox
eolivelli opened a new issue #1004: Client of BookKeeper 4.6.1 imports dependencies to netty-common and netty-all URL: https://github.com/apache/bookkeeper/issues/1004 A brand new client with this dependency ``` org.apache.bookkeeper

[GitHub] eolivelli opened a new pull request #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common

2018-01-17 Thread GitBox
eolivelli opened a new pull request #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common URL: https://github.com/apache/bookkeeper/pull/1005 Change "netty-common" to "netty-all" in order to simplify packaging of poms

[GitHub] eolivelli commented on issue #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common

2018-01-17 Thread GitBox
eolivelli commented on issue #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common URL: https://github.com/apache/bookkeeper/pull/1005#issuecomment-358543257 see #1004 This is an automated

[GitHub] eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003#issuecomment-358544865 Just for completenessthe best command to test the full suite is `mvn verify`

[GitHub] eolivelli commented on issue #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common

2018-01-17 Thread GitBox
eolivelli commented on issue #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common URL: https://github.com/apache/bookkeeper/pull/1005#issuecomment-358547843 This is the dependency tree after this change: ``` \-

[GitHub] eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003#issuecomment-358533859 odd fact: if I run the tests inside this directory, all runs fine bookkeeper/tests/backward so this fails ```

[GitHub] eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1003: All Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1003#issuecomment-358534306 @sijie do you think this is a blocker for release ? Somehow tests pass, it is a problem of the global configuration of

[GitHub] eolivelli opened a new pull request #1006: Issue-1003 Backward Compatility tests fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli opened a new pull request #1006: Issue-1003 Backward Compatility tests fail on branch-4.6 URL: https://github.com/apache/bookkeeper/pull/1006 Fix the pom in order to clean up compatibility tests for branch-4.6. BookKeeper server shaded stuff was picked from 4.7 branch but the

[GitHub] eolivelli commented on issue #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common

2018-01-17 Thread GitBox
eolivelli commented on issue #1005: Issue-1004 Client of BookKeeper 4.6.1 imports dependencies to netty-common URL: https://github.com/apache/bookkeeper/pull/1005#issuecomment-358547731 @sijie @merlimat I have addressed Sijie's comment on Slack. It is better to port the same change

[GitHub] eolivelli commented on issue #1006: Issue-1003 bookkeeper-server shaded artifact test fail on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1006: Issue-1003 bookkeeper-server shaded artifact test fail on branch-4.6 URL: https://github.com/apache/bookkeeper/pull/1006#issuecomment-358549610 @sijie I think that the problem is the same for which we have introduced bookkeeper-server-shaded artifact

[GitHub] sijie commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets

2018-01-17 Thread GitBox
sijie commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets URL: https://github.com/apache/bookkeeper/pull/993#discussion_r162149256 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

[GitHub] athanatos commented on issue #993: PendingReadOp: improve logging for speculative read targets

2018-01-17 Thread GitBox
athanatos commented on issue #993: PendingReadOp: improve logging for speculative read targets URL: https://github.com/apache/bookkeeper/pull/993#issuecomment-358501628 @sijie Switched to debug. This is an automated message

[GitHub] eolivelli commented on issue #1001: DoubleByteBufferTest fails on branch-4.6

2018-01-17 Thread GitBox
eolivelli commented on issue #1001: DoubleByteBufferTest fails on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1001#issuecomment-358525563 @sijie see #1002 diff This is an automated message from the Apache Git

[GitHub] eolivelli opened a new pull request #1002: Issue-1001 merge DoubleByteBuffer from master

2018-01-17 Thread GitBox
eolivelli opened a new pull request #1002: Issue-1001 merge DoubleByteBuffer from master URL: https://github.com/apache/bookkeeper/pull/1002 Ports current version of DoubleByteBuffer from aster This is an automated message

[GitHub] sijie closed pull request #974: Utilities for working with Arquillian and Docker

2018-01-17 Thread GitBox
sijie closed pull request #974: Utilities for working with Arquillian and Docker URL: https://github.com/apache/bookkeeper/pull/974 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on issue #974: Utilities for working with Arquillian and Docker

2018-01-17 Thread GitBox
sijie commented on issue #974: Utilities for working with Arquillian and Docker URL: https://github.com/apache/bookkeeper/pull/974#issuecomment-358499422 merged #974. #975 should be unblocked. This is an automated message

[GitHub] sijie commented on issue #1001: DoubleByteBufferTest fails on branch-4.6

2018-01-17 Thread GitBox
sijie commented on issue #1001: DoubleByteBufferTest fails on branch-4.6 URL: https://github.com/apache/bookkeeper/issues/1001#issuecomment-358524454 @eolivelli can you diff the difference between branch? This is an

[GitHub] eolivelli opened a new pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
eolivelli opened a new pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996 This is a port from Pulsar, DoubleByteBuf has problems with Netty Native Transport see https://github.com/apache/incubator-pulsar/pull/1056

[GitHub] eolivelli commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
eolivelli commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996#discussion_r162047103 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DoubleByteBuf.java ## @@ -370,7

[GitHub] eolivelli commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12

2018-01-17 Thread GitBox
eolivelli commented on a change in pull request #996: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/996#discussion_r162047103 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DoubleByteBuf.java ## @@ -370,7

[GitHub] ivankelly opened a new pull request #994: Issue #981: Revert "ISSUE #561: Remove exec commands to start in the shell pid"

2018-01-17 Thread GitBox
ivankelly opened a new pull request #994: Issue #981: Revert "ISSUE #561: Remove exec commands to start in the shell pid" URL: https://github.com/apache/bookkeeper/pull/994 This reverts commit 7d7497b70507ea3d31b184ebe04d98c733e2cf5b.

Build failed in Jenkins: distributedlog-release-nightly-snapshot #139

2018-01-17 Thread Apache Jenkins Server
See -- [...truncated 202.11 KB...] [INFO] Uploaded: