[GitHub] eolivelli commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

eolivelli commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166775350 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java

[GitHub] eolivelli commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

eolivelli commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166776045 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java

[GitHub] jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166801865 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataClientDriver.java

[GitHub] jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166803834 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java ##

[GitHub] jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166797172 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java

[GitHub] jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

jvrao commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166801865 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataClientDriver.java

[GitHub] sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166784312 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java ##

[GitHub] sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166785597 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java ##

[GitHub] sijie commented on a change in pull request #1129: Upgrade JaCoCo and Upgrade Coveralls.io configuration

sijie commented on a change in pull request #1129: Upgrade JaCoCo and Upgrade Coveralls.io configuration URL: https://github.com/apache/bookkeeper/pull/1129#discussion_r166783404 ## File path: pom.xml ## @@ -389,6 +389,9 @@ org.eluder.coveralls

[GitHub] sijie commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher

sijie commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r166782888 ## File path:

[GitHub] sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166849137 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java ##

[GitHub] eolivelli commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

eolivelli commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r166845150 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java

[GitHub] eolivelli commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher

eolivelli commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r166847317 ## File path:

[GitHub] sijie commented on a change in pull request #1129: WIP Upgrade JaCoCo and Upgrade Coveralls.io configuration

sijie commented on a change in pull request #1129: WIP Upgrade JaCoCo and Upgrade Coveralls.io configuration URL: https://github.com/apache/bookkeeper/pull/1129#discussion_r166849508 ## File path: pom.xml ## @@ -389,6 +389,9 @@ org.eluder.coveralls

[GitHub] sijie commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available

sijie commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available URL: https://github.com/apache/bookkeeper/pull/1120#issuecomment-363724636 @jiazhai the change looks good to me now. +1

[GitHub] sijie commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

sijie commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#discussion_r166613240 ## File path:

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r166609452 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java ##

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r166611645 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java ##

Jenkins build is still unstable: bookkeeper_postcommit_master_java8 #34

See

[GitHub] sijie opened a new pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

sijie opened a new pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127 Descriptions of the changes in this PR: - introduce a new setting `metadataServiceUrl` for replacing implementation specific settings

[GitHub] sijie opened a new pull request #1128: BP-29 (task 2) : Make LedgerManagerFactory a pure interface

sijie opened a new pull request #1128: BP-29 (task 2) : Make LedgerManagerFactory a pure interface URL: https://github.com/apache/bookkeeper/pull/1128 Descriptions of the changes in this PR: The logic in LedgerManagerFactory#newLedgerManagerFactory is effectively the logic

Jenkins build is still unstable: bookkeeper_release_nightly_snapshot #52

See

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #35

See

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r14497 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java ##

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-363816947 @reddycharan I think I addressed all your comments. This is an automated message from the

[GitHub] eolivelli opened a new pull request #1129: Upgrade JaCoCo and Upgrade Coveralls.io configuration

eolivelli opened a new pull request #1129: Upgrade JaCoCo and Upgrade Coveralls.io configuration URL: https://github.com/apache/bookkeeper/pull/1129 - Upgrade JaCoCo to version 0.8.0 which supports Java 9 - Update Coveralls.io configuration in order to handle NAR-plugin files -

[GitHub] sijie opened a new pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher

sijie opened a new pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher URL: https://github.com/apache/bookkeeper/pull/1130 Descriptions of the changes in this PR: cherry-pick twitter/bookkeeper@dfcda5cc2efdc03db99fe126499f8e3347f50484 >

[GitHub] sijie commented on issue #1130: (WIP) handle zookeeper session expire in ensemble watcher

sijie commented on issue #1130: (WIP) handle zookeeper session expire in ensemble watcher URL: https://github.com/apache/bookkeeper/pull/1130#issuecomment-363826829 I think this change was actually in master when we contributed back ensemble watcher. but it was commented out on waiting

[GitHub] eolivelli commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher

eolivelli commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r166687419 ## File path: