[GitHub] sijie opened a new pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie opened a new pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507 Descriptions of the changes in this PR: *Motivation* The getSerializeLen() returned by StringUtf8Coder is different from the seri

[GitHub] sijie commented on issue #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie commented on issue #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507#issuecomment-396026251 This PR includes changes from #1506 to allow it pass precommit jobs. --

[GitHub] infodog commented on issue #1476: recycle already.

infodog commented on issue #1476: recycle already. URL: https://github.com/apache/bookkeeper/issues/1476#issuecomment-396030681 @sijie OK, I interested in providing a fix. This is an automated message from the Apache Git Serv

[GitHub] eolivelli commented on a change in pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

eolivelli commented on a change in pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507#discussion_r194251915 ## File path: stream/common/src/test/java/org/apache/bookkeeper/common/coder/TestByteArrayCoder.j

[GitHub] eolivelli opened a new pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli opened a new pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508 Descriptions of the changes in this PR: ### Motivation The test if flaky because the Journal is putting some ForceWriteRequest

[GitHub] eolivelli commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194256145 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalForceTest.java ##

Jenkins build is back to stable : bookkeeper_release_branch_46 #63

See

[GitHub] infodog opened a new pull request #1509: solve #1476 issue.

infodog opened a new pull request #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509 Descriptions of the changes in this PR: The issue #1476 is caused by peculative reads with object recycling, same request object will be added to the CompletionObjects mul

Jenkins build is still unstable: bookkeeper_postcommit_master_java8 #164

See

[GitHub] eolivelli commented on issue #1509: solve #1476 issue.

eolivelli commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396057469 Thank you @infodog for looking into this. How can you prove the fix addresses the problem? Is there any test case we can add in order ensure wr won't f

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #165

See

[GitHub] sijie closed pull request #1506: [table service] Fix ZkClusterMetadataStoreTest

sijie closed pull request #1506: [table service] Fix ZkClusterMetadataStoreTest URL: https://github.com/apache/bookkeeper/pull/1506 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] sijie commented on a change in pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie commented on a change in pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507#discussion_r194267339 ## File path: stream/common/src/test/java/org/apache/bookkeeper/common/coder/TestByteArrayCoder.java

[GitHub] sijie commented on a change in pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie commented on a change in pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507#discussion_r194267438 ## File path: stream/common/src/test/java/org/apache/bookkeeper/common/coder/TestByteArrayCoder.java

[GitHub] sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194267504 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java ## @@ -390,6 +39

[GitHub] sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194267511 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalForceTest.java ##

[GitHub] eolivelli commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#issuecomment-396080404 Apart from @sijie comments. The test is passed on CI. Let's kick it a couple of times to see if flakiness went away

[GitHub] eolivelli commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#issuecomment-396080427 rerun bookie tests This is an automated message from the Apache Git Serv

[GitHub] eolivelli commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#issuecomment-396080653 rerun bookkeeper-server bookie tests This is an automated message from t

[GitHub] sijie commented on issue #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie commented on issue #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507#issuecomment-396119830 run integration tests This is an automated message from the Ap