[GitHub] [bookkeeper] StevenLuMT commented on issue #2927: EntryLocationIndex.getLastEntryInLedger has bug when the ledger has been deleted

2022-03-01 Thread GitBox
StevenLuMT commented on issue #2927: URL: https://github.com/apache/bookkeeper/issues/2927#issuecomment-1055386960 bugfix in pr #2946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] StevenLuMT closed issue #2927: EntryLocationIndex.getLastEntryInLedger has bug when the ledger has been deleted

2022-03-01 Thread GitBox
StevenLuMT closed issue #2927: URL: https://github.com/apache/bookkeeper/issues/2927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] StevenLuMT commented on issue #2760: Bookkeeper shutdown when zookeeper connection just timeout

2022-03-01 Thread GitBox
StevenLuMT commented on issue #2760: URL: https://github.com/apache/bookkeeper/issues/2760#issuecomment-1055388556 bugfix in pr #2958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil

2022-03-01 Thread GitBox
StevenLuMT commented on pull request #3056: URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055390478 @dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276 @sijie If you have time, please help me review it, thank you -- This is an automated message from

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil

2022-03-01 Thread GitBox
StevenLuMT removed a comment on pull request #3056: URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055371711 @dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276 If you have time, please help me review it, thank you -- This is an automated message from

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3036: add async or sync for :location rocksdb write

2022-03-01 Thread GitBox
StevenLuMT commented on pull request #3036: URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1055390848 @dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 @sijie If you have time, please help me review it, thank you. -- This is an automated message from the Apache Git

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3036: add async or sync for :location rocksdb write

2022-03-01 Thread GitBox
StevenLuMT removed a comment on pull request #3036: URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1055371419 @dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 If you have time, please help me review it, thank you. -- This is an automated message from the Apache Git

[GitHub] [bookkeeper] eolivelli merged pull request #3077: [tests] Replace powermockito usages with mockito-inline - 'tools' submodule

2022-03-01 Thread GitBox
eolivelli merged pull request #3077: URL: https://github.com/apache/bookkeeper/pull/3077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] nodece closed pull request #3076: Fix release the CompletionKey

2022-03-01 Thread GitBox
nodece closed pull request #3076: URL: https://github.com/apache/bookkeeper/pull/3076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] nodece commented on pull request #3076: Fix release the CompletionKey

2022-03-01 Thread GitBox
nodece commented on pull request #3076: URL: https://github.com/apache/bookkeeper/pull/3076#issuecomment-1056059894 Currently, this codebase is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-03-01 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1047434028 I submitted a PR (https://github.com/apache/pulsar/pull/14407) accordingly in pulsar to change the usage of the new pendingAcks: this.pendingAcks

[GitHub] [bookkeeper] nicoloboschi commented on pull request #3077: [tests] Replace powermockito usages with mockito-inline - 'tools' submodule

2022-03-01 Thread GitBox
nicoloboschi commented on pull request #3077: URL: https://github.com/apache/bookkeeper/pull/3077#issuecomment-1055465331 @eolivelli @merlimat PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil

2022-03-01 Thread GitBox
StevenLuMT commented on pull request #3056: URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055371711 @dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276 If you have time, please help me review it, thank you -- This is an automated message from the

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3036: add async or sync for :location rocksdb write

2022-03-01 Thread GitBox
StevenLuMT removed a comment on pull request #3036: URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1054870615 @dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 If you have time, please help me review it, thank you. -- This is an automated message from the Apache Git

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3036: add async or sync for :location rocksdb write

2022-03-01 Thread GitBox
StevenLuMT commented on pull request #3036: URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1055371419 @dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 If you have time, please help me review it, thank you. -- This is an automated message from the Apache Git Service.