[GitHub] [bookkeeper] Shoothzj commented on pull request #3091: Bump netty version to 4.1.75.Final

2022-03-10 Thread GitBox
Shoothzj commented on pull request #3091: URL: https://github.com/apache/bookkeeper/pull/3091#issuecomment-1064778673 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] Shoothzj removed a comment on pull request #3091: Bump netty version to 4.1.75.Final

2022-03-10 Thread GitBox
Shoothzj removed a comment on pull request #3091: URL: https://github.com/apache/bookkeeper/pull/3091#issuecomment-1064721706 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3092: add unit tests for reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3092: URL: https://github.com/apache/bookkeeper/pull/3092#issuecomment-1064744129 @eolivelli @merlimat PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] lhotari opened a new issue #3093: PendingReadOp has a buffer leak in the case of errors

2022-03-10 Thread GitBox
lhotari opened a new issue #3093: URL: https://github.com/apache/bookkeeper/issues/3093 **BUG REPORT** ***Describe the bug*** The code in PendingReadOp doesn't handle failure cases. This code doesn't ever get executed:

[GitHub] [bookkeeper] lordcheng10 opened a new pull request #3092: add unit tests for reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 opened a new pull request #3092: URL: https://github.com/apache/bookkeeper/pull/3092 ### Motivation add unit tests for "reduce unnecessary expansions for ConcurrentLong map and set" Add corresponding unit tests for the previous PR:

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1064743953 > Merged to master branch. Feel free to add the tests if you want as follow up work. Not strictly needed Done: https://github.com/apache/bookkeeper/pull/3092

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1064718307 > Merged to master branch. Feel free to add the tests if you want as follow up work. Not strictly needed OK, I will add unit tests -- This is an automated

[GitHub] [bookkeeper] Shoothzj removed a comment on pull request #3087: [security] Bump bc fips version from 1.0.2.1 to 1.0.2.3

2022-03-10 Thread GitBox
Shoothzj removed a comment on pull request #3087: URL: https://github.com/apache/bookkeeper/pull/3087#issuecomment-1063735103 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [bookkeeper] Shoothzj commented on pull request #3087: [security] Bump bc fips version from 1.0.2.1 to 1.0.2.3

2022-03-10 Thread GitBox
Shoothzj commented on pull request #3087: URL: https://github.com/apache/bookkeeper/pull/3087#issuecomment-1064698275 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3092: add unit tests for reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3092: URL: https://github.com/apache/bookkeeper/pull/3092#issuecomment-1064745299 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3082: fix reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3082: URL: https://github.com/apache/bookkeeper/pull/3082#issuecomment-1064745213 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] Shoothzj opened a new pull request #3091: Bump netty version to 4.1.75.Final

2022-03-10 Thread GitBox
Shoothzj opened a new pull request #3091: URL: https://github.com/apache/bookkeeper/pull/3091 ### Motivation Changelog: https://netty.io/news/2022/03/10/4-1-75-Final.html Netty 4.1.75 has https://github.com/netty/netty/issues/12103 feature that

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3092: add unit tests for reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3092: URL: https://github.com/apache/bookkeeper/pull/3092#issuecomment-1064769483 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] Shoothzj commented on pull request #3091: Bump netty version to 4.1.75.Final

2022-03-10 Thread GitBox
Shoothzj commented on pull request #3091: URL: https://github.com/apache/bookkeeper/pull/3091#issuecomment-1064721706 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lhotari commented on issue #3093: PendingReadOp has a buffer leak in the case of errors

2022-03-10 Thread GitBox
lhotari commented on issue #3093: URL: https://github.com/apache/bookkeeper/issues/3093#issuecomment-1064858164 I misread the code... there's an inner class. closing. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [bookkeeper] lhotari closed issue #3093: PendingReadOp has a buffer leak in the case of errors

2022-03-10 Thread GitBox
lhotari closed issue #3093: URL: https://github.com/apache/bookkeeper/issues/3093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3082: fix reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3082: URL: https://github.com/apache/bookkeeper/pull/3082#issuecomment-1064717162 > Do we have a test that covers this change? @eolivelli Fixed.PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3082: fix reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 commented on pull request #3082: URL: https://github.com/apache/bookkeeper/pull/3082#issuecomment-1064744906 @StevenLuMT @hangc0276 PTAL,thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3092: add unit tests for reduce unnecessary expansions

2022-03-10 Thread GitBox
lordcheng10 edited a comment on pull request #3092: URL: https://github.com/apache/bookkeeper/pull/3092#issuecomment-1064744129 @eolivelli @merlimat @StevenLuMT PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2931: Add ensemble relocation command which adheres to placement policy

2022-03-10 Thread GitBox
eolivelli commented on a change in pull request #2931: URL: https://github.com/apache/bookkeeper/pull/2931#discussion_r823566877 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java ## @@ -1071,4 +1074,175 @@

[GitHub] [bookkeeper] eolivelli commented on pull request #3084: Upgrade ZooKeeper dependency to 3.8.0

2022-03-10 Thread GitBox
eolivelli commented on pull request #3084: URL: https://github.com/apache/bookkeeper/pull/3084#issuecomment-1063789689 @dlg99 regarding OWASP we can follow this discussion https://github.com/apache/pulsar/pull/14630 basically there are false positives about "Jetty" that

[GitHub] [bookkeeper] hangc0276 commented on pull request #2642: fix region/rack aware placement police replace bookie bug

2022-03-10 Thread GitBox
hangc0276 commented on pull request #2642: URL: https://github.com/apache/bookkeeper/pull/2642#issuecomment-1064052451 ping @eolivelli , Please help review this PR, thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [bookkeeper] nicoloboschi opened a new pull request #3090: [website] update website every time there is a change

2022-03-10 Thread GitBox
nicoloboschi opened a new pull request #3090: URL: https://github.com/apache/bookkeeper/pull/3090 ### Motivation At the moment every night at 00:00 UTC the website job will try to update the `asf-site` branch content. It is better to run this job whenever a new change is