[GitHub] [bookkeeper] Shoothzj commented on pull request #3246: FIX TODO move bookkeeper-stats and bookkeeper-stats-providers as submodules of stats

Shoothzj commented on PR #3246: URL: https://github.com/apache/bookkeeper/pull/3246#issuecomment-1108140343 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] hangc0276 commented on pull request #3192: Fix compaction throttle imprecise

hangc0276 commented on PR #3192: URL: https://github.com/apache/bookkeeper/pull/3192#issuecomment-1109302185 > Good work > > We definitely need tests about these new methods @eolivelli I removed the duplicated new methods, and return the prefetched bytes when calling

[GitHub] [bookkeeper] dlg99 merged pull request #3201: Correct the method signature within annotations

dlg99 merged PR #3201: URL: https://github.com/apache/bookkeeper/pull/3201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] hangc0276 commented on pull request #2535: fix ledgerDirsMonitor's listener doesn't work well on dbLedgerStorage

hangc0276 commented on PR #2535: URL: https://github.com/apache/bookkeeper/pull/2535#issuecomment-1109320923 It has been fixed by https://github.com/apache/bookkeeper/pull/2627 , close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [bookkeeper] hangc0276 closed pull request #2535: fix ledgerDirsMonitor's listener doesn't work well on dbLedgerStorage

hangc0276 closed pull request #2535: fix ledgerDirsMonitor's listener doesn't work well on dbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/2535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] hangc0276 commented on pull request #3228: Add get under replicated ledger count

hangc0276 commented on PR #3228: URL: https://github.com/apache/bookkeeper/pull/3228#issuecomment-1109261903 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] hangc0276 commented on pull request #3228: Add get under replicated ledger count

hangc0276 commented on PR #3228: URL: https://github.com/apache/bookkeeper/pull/3228#issuecomment-1109261800 > Please add a test (see `ListUnderReplicatedCommandTest`) I have been add test `testOnlyDisplayLedgerCount`. Please help take a look, thanks a lot @dlg99 -- This is an

[GitHub] [bookkeeper] Shoothzj commented on pull request #3246: FIX TODO move bookkeeper-stats and bookkeeper-stats-providers as submodules of stats

Shoothzj commented on PR #3246: URL: https://github.com/apache/bookkeeper/pull/3246#issuecomment-1108217719 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] dlg99 commented on pull request #3244: [WIP] fix flaky test BookieZKExpireTest.testBookieServerZKExpireBehaviour

dlg99 commented on PR #3244: URL: https://github.com/apache/bookkeeper/pull/3244#issuecomment-1109099529 Looks like this didn't work: ``` Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.088 s <<< FAILURE! - in org.apache.bookkeeper.test.BookieZKExpireTest

[GitHub] [bookkeeper] dlg99 merged pull request #3232: Bump jetty to 9.4.46.v20220331 to get rid of CVE-2021-34429

dlg99 merged PR #3232: URL: https://github.com/apache/bookkeeper/pull/3232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] dlg99 closed issue #3222: Read ledger returns "Bookie handle is not available" when one bookie is up but the ledger is empty.

dlg99 closed issue #3222: Read ledger returns "Bookie handle is not available" when one bookie is up but the ledger is empty. URL: https://github.com/apache/bookkeeper/issues/3222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [bookkeeper] dlg99 merged pull request #3240: Fix read empty ledger exception using bookkeeper admin

dlg99 merged PR #3240: URL: https://github.com/apache/bookkeeper/pull/3240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] Shoothzj commented on pull request #3242: fix some jdk17 test problem

Shoothzj commented on PR #3242: URL: https://github.com/apache/bookkeeper/pull/3242#issuecomment-1108702811 @eolivelli @dlg99 @merlimat @pkumar-singh PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] hangc0276 commented on pull request #3240: Fix read empty ledger exception using bookkeeper admin

hangc0276 commented on PR #3240: URL: https://github.com/apache/bookkeeper/pull/3240#issuecomment-1108752566 > The motivation also need an update? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [bookkeeper] Shoothzj commented on pull request #3246: FIX TODO move bookkeeper-stats and bookkeeper-stats-providers as submodules of stats

Shoothzj commented on PR #3246: URL: https://github.com/apache/bookkeeper/pull/3246#issuecomment-1108412645 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] Shoothzj commented on pull request #3246: FIX TODO move bookkeeper-stats and bookkeeper-stats-providers as submodules of stats

Shoothzj commented on PR #3246: URL: https://github.com/apache/bookkeeper/pull/3246#issuecomment-1108702525 @eolivelli @dlg99 @nicoloboschi @merlimat @pkumar-singh PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [bookkeeper] Shoothzj commented on pull request #3246: FIX TODO move bookkeeper-stats and bookkeeper-stats-providers as submodules of stats

Shoothzj commented on PR #3246: URL: https://github.com/apache/bookkeeper/pull/3246#issuecomment-1108580406 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] dlg99 merged pull request #3213: Format log statements

dlg99 merged PR #3213: URL: https://github.com/apache/bookkeeper/pull/3213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] dlg99 merged pull request #3227: Fix bookie shell help command exception

dlg99 merged PR #3227: URL: https://github.com/apache/bookkeeper/pull/3227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3228: Add get under replicated ledger count

dlg99 commented on code in PR #3228: URL: https://github.com/apache/bookkeeper/pull/3228#discussion_r858085069 ## site3/website/docs/reference/cli.md: ## @@ -342,12 +342,13 @@ $ bin/bookkeeper shell listunderreplicated \ ``` -| Flag

[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3228: Add get under replicated ledger count

dlg99 commented on code in PR #3228: URL: https://github.com/apache/bookkeeper/pull/3228#discussion_r858085349 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java: ## @@ -677,12 +682,14 @@ int runCmd(CommandLine cmdLine) throws Exception {

[GitHub] [bookkeeper] Shoothzj commented on pull request #3244: [WIP] fix flaky test BookieZKExpireTest.testBookieServerZKExpireBehaviour

Shoothzj commented on PR #3244: URL: https://github.com/apache/bookkeeper/pull/3244#issuecomment-1109122890 > Looks like this didn't work: > > ``` > > Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.088 s <<< FAILURE! - in

[GitHub] [bookkeeper] dlg99 commented on pull request #3214: Issue 3070: Fix bug where checkAllLedgers gets stuck when read throttling is enabled

dlg99 commented on PR #3214: URL: https://github.com/apache/bookkeeper/pull/3214#issuecomment-1109162512 @massakam is it possible to avoid the extra executor? I think the problem is that checkFragments/verifyLedgerFragment tries to acquire a permit from a callback in

[GitHub] [bookkeeper] dlg99 commented on pull request #3246: FIX TODO move bookkeeper-stats and bookkeeper-stats-providers as submodules of stats

dlg99 commented on PR #3246: URL: https://github.com/apache/bookkeeper/pull/3246#issuecomment-1109172960 Overall LGTM with one catch: This will change names of dependencies (org.apache.bookkeeper:bookkeeper-stats-providers -> org.apache.bookkeeper.stats:bookkeeper-stats-providers)