[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145789040 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

[GitHub] asfgit commented on issue #643: BP-14 part 2 - client side changes

asfgit commented on issue #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337963302 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #643: BP-14 part 2 - client side changes

asfgit commented on issue #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337909287 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #643: BP-14 part 2 - client side changes

asfgit commented on issue #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337907689 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: bookkeeper-master #1922

See Changes: [ivan] Fixed ref counting release on read errors [ivan] Fix concurrent v2 reads on the same ledger/entry -- [...truncated 40.86 KB...] Tests run: 4,

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145695709 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/SyncSupported.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145693862 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RoundRobinDistributionSchedule.java

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145691150 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -362,6

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145690148 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -84,15

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684521 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java ## @@

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684461 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java ## @@

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684060 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java ## @@ -160,6

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684063 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java ## @@ -160,6

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145680332 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -193,3 +212,9 @@

[GitHub] asfgit commented on issue #643: BP-14 part 2 - client side changes

asfgit commented on issue #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337872118 Refer to this link for build results (access rights to CI server needed):

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631534 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java ## @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145640557 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145634367 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145634439 ## File path: bookkeeper-server/src/main/proto/DataFormats.proto ## @@ -58,6 +58,15 @@ message

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145633907 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145633790 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145633637 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145632683 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145632702 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -193,3 +212,9 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145632181 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631841 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631534 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java ## @@

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #79

See