[GitHub] merlimat opened a new pull request #720: Fixed simultaneus reads on same ledger/entry with v2 protocol

merlimat opened a new pull request #720: Fixed simultaneus reads on same ledger/entry with v2 protocol URL: https://github.com/apache/bookkeeper/pull/720 This change is coming from yahoo branch at yahoo/bookkeeper@ce7b0f7 With v2 protocol there's no way to disambiguate the read

[GitHub] merlimat closed issue #719: Fixed simultaneus reads on same ledger/entry with v2 protocol

merlimat closed issue #719: Fixed simultaneus reads on same ledger/entry with v2 protocol URL: https://github.com/apache/bookkeeper/issues/719 This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat opened a new issue #719: Fixed simultaneus reads on same ledger/entry with v2 protocol

merlimat opened a new issue #719: Fixed simultaneus reads on same ledger/entry with v2 protocol URL: https://github.com/apache/bookkeeper/issues/719 This change is coming from yahoo branch at https://github.com/yahoo/bookkeeper/commit/ce7b0f7d0fbb4c24ce13bd2d86e48c5c8143167a With

[GitHub] asfgit commented on issue #718: Issue 490: Add a flag to not serialize `ctime` field

asfgit commented on issue #718: Issue 490: Add a flag to not serialize `ctime` field URL: https://github.com/apache/bookkeeper/pull/718#issuecomment-343637165 FAILURE --none-- This is an automated message from the

[GitHub] sijie commented on issue #718: Issue 490: Add a flag to not serialize `ctime` field

sijie commented on issue #718: Issue 490: Add a flag to not serialize `ctime` field URL: https://github.com/apache/bookkeeper/pull/718#issuecomment-343634826 @eolivelli since the `ctime` feature was added by you, I am adding a flag for it. I turn it off to simplify the upgrade story. it

[GitHub] sijie commented on issue #718: Issue 490: Add a flag to not serialize `ctime` field

sijie commented on issue #718: Issue 490: Add a flag to not serialize `ctime` field URL: https://github.com/apache/bookkeeper/pull/718#issuecomment-343634746 This is the pull request for #490 This is an automated message

[GitHub] sijie opened a new pull request #718: Issue 490: Add a flag to not serialize `ctime` field

sijie opened a new pull request #718: Issue 490: Add a flag to not serialize `ctime` field URL: https://github.com/apache/bookkeeper/pull/718 Descriptions of the changes in this PR: This request is for DL bookkeeper version upgrade. Because twitter's bk version doesn't

[GitHub] asfgit commented on issue #715: Issue 694: ReadHandle doesn't have getLength() method

asfgit commented on issue #715: Issue 694: ReadHandle doesn't have getLength() method URL: https://github.com/apache/bookkeeper/pull/715#issuecomment-343631048 SUCCESS --none-- This is an automated message from the

[GitHub] asfgit commented on issue #717: Issue 716: PendingAddOp accesses a released ByteBuf

asfgit commented on issue #717: Issue 716: PendingAddOp accesses a released ByteBuf URL: https://github.com/apache/bookkeeper/pull/717#issuecomment-343630758 FAILURE --none-- This is an automated message from the

[GitHub] sijie opened a new pull request #717: Issue 716: PendingAddOp accessed a released ByteBuf

sijie opened a new pull request #717: Issue 716: PendingAddOp accessed a released ByteBuf URL: https://github.com/apache/bookkeeper/pull/717 Descriptions of the changes in this PR: - release `toSend` bytebuf only when a PendingAddOp is recycled. - fix MockBookKeeperTestCase to

[GitHub] sijie closed issue #691: Create separate module for Protobuf files

sijie closed issue #691: Create separate module for Protobuf files URL: https://github.com/apache/bookkeeper/issues/691 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie closed pull request #711: ISSUE #691: Move generated files into their own module

sijie closed pull request #711: ISSUE #691: Move generated files into their own module URL: https://github.com/apache/bookkeeper/pull/711 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #716: PendingAddOp accessed a released ByteBuf

sijie commented on issue #716: PendingAddOp accessed a released ByteBuf URL: https://github.com/apache/bookkeeper/issues/716#issuecomment-343624712 @jiazhai @eolivelli fyi, since you are the release managers of `4.6.0` and `4.5.1`.

[GitHub] sijie opened a new issue #716: PendingAddOp accessed a released ByteBuf

sijie opened a new issue #716: PendingAddOp accessed a released ByteBuf URL: https://github.com/apache/bookkeeper/issues/716 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run `BookKeeperApiTest` - What did you expect to see?

[GitHub] sijie opened a new pull request #715: Issue 694: ReadHandle doesn't have getLength() method

sijie opened a new pull request #715: Issue 694: ReadHandle doesn't have getLength() method URL: https://github.com/apache/bookkeeper/pull/715 Descriptions of the changes in this PR: - add `getLength()` to ReadHandle interface - add `getLastAddPushed` to WriteHandle interface

[GitHub] asfgit commented on issue #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies

asfgit commented on issue #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies URL: https://github.com/apache/bookkeeper/pull/714#issuecomment-343617702 FAILURE --none-- This is

[GitHub] asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-343615471 FAILURE --none-- This

[GitHub] sijie commented on issue #409: BookKeeper Server distribution contains useless jar guava-20.0.jar

sijie commented on issue #409: BookKeeper Server distribution contains useless jar guava-20.0.jar URL: https://github.com/apache/bookkeeper/issues/409#issuecomment-343609825 closed this as "won't fix" This is an automated

[GitHub] sijie closed issue #409: BookKeeper Server distribution contains useless jar guava-20.0.jar

sijie closed issue #409: BookKeeper Server distribution contains useless jar guava-20.0.jar URL: https://github.com/apache/bookkeeper/issues/409 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie closed pull request #687: Issue-409 BookKeeper Server distribution contains useless jar guava

sijie closed pull request #687: Issue-409 BookKeeper Server distribution contains useless jar guava URL: https://github.com/apache/bookkeeper/pull/687 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie commented on issue #687: Issue-409 BookKeeper Server distribution contains useless jar guava

sijie commented on issue #687: Issue-409 BookKeeper Server distribution contains useless jar guava URL: https://github.com/apache/bookkeeper/pull/687#issuecomment-343609682 sure let me close it. mark it as "won't fix" This

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150356218 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150356199 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150355958 ## File path:

[GitHub] asfgit commented on issue #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies

asfgit commented on issue #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies URL: https://github.com/apache/bookkeeper/pull/714#issuecomment-343601041 FAILURE --none-- This is

[GitHub] sijie opened a new pull request #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies

sijie opened a new pull request #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies URL: https://github.com/apache/bookkeeper/pull/714 Descriptions of the changes in this PR: This is a change ported from twitter branch. - Enable

[GitHub] ivankelly opened a new issue #713: New apis should be experimental until they've been used a bit

ivankelly opened a new issue #713: New apis should be experimental until they've been used a bit URL: https://github.com/apache/bookkeeper/issues/713 The new client apis in master haven't been used enough for us to commit to maintaining backward compatability with them. We need to mark

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150311515 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150303956 ## File path:

[GitHub] eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150290589 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150289228 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150289228 ## File path:

[GitHub] eolivelli commented on issue #687: Issue-409 BookKeeper Server distribution contains useless jar guava

eolivelli commented on issue #687: Issue-409 BookKeeper Server distribution contains useless jar guava URL: https://github.com/apache/bookkeeper/pull/687#issuecomment-343528269 after all I think that we can close this issue as won't fix. it is not worth to complicate the build. Guava is

[GitHub] sijie commented on issue #687: Issue-409 BookKeeper Server distribution contains useless jar guava

sijie commented on issue #687: Issue-409 BookKeeper Server distribution contains useless jar guava URL: https://github.com/apache/bookkeeper/pull/687#issuecomment-343526816 @eolivelli if you run `mvn dependency:tree`, you will find guava is used at multiple modules (e.g.

[GitHub] eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150284839 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150284497 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150284101 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150283389 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150282590 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150282034 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150281595 ## File path:

[GitHub] asfgit commented on issue #711: ISSUE #691: Move generated files into their own module

asfgit commented on issue #711: ISSUE #691: Move generated files into their own module URL: https://github.com/apache/bookkeeper/pull/711#issuecomment-343469331 FAILURE --none-- This is an automated message from the

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150200741 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150196445 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150201065 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150201018 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150203340 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150196941 ## File path:

[GitHub] eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150197544 ## File path:

[GitHub] eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150197544 ## File path:

[GitHub] jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343430652 what a coincidence for us to do it at same time, will close this, since it is merged.

[GitHub] jiazhai closed pull request #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

jiazhai closed pull request #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ivankelly commented on a change in pull request #706: Bookies should not queue read request indefinitely

ivankelly commented on a change in pull request #706: Bookies should not queue read request indefinitely URL: https://github.com/apache/bookkeeper/pull/706#discussion_r150194893 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestMaxSizeWorkersQueue.java

[GitHub] ivankelly commented on issue #711: ISSUE #691: Move generated files into their own module

ivankelly commented on issue #711: ISSUE #691: Move generated files into their own module URL: https://github.com/apache/bookkeeper/pull/711#issuecomment-343429555 @eolivelli Addressed comments in latest push This is an

[GitHub] eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343425824 are you trying too @jiazhai ? This is

[GitHub] jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343425606 I will have a try This is an automated

[GitHub] eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343425654 I am merging this into 4.5 This is an

[GitHub] asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-343425644 FAILURE --none-- This

Jenkins build became unstable: distributedlog-release-nightly-snapshot #76

See

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #98

See