[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152196993 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152196627 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152196082 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152195920 ## File path:

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152195477 ## File path:

Jenkins build became unstable: distributedlog-nightly-build #493

2017-11-20 Thread Apache Jenkins Server
See

[GitHub] sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
sijie commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152194844 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193201 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193185 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193172 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193166 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193139 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193123 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193148 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193129 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193092 ## File path:

[GitHub] jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
jvrao commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r152193112 ## File path:

[GitHub] jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-20 Thread GitBox
jiazhai commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r152178441 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java

[GitHub] sijie commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-20 Thread GitBox
sijie commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r152177922 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java

[GitHub] zhaijack opened a new issue #750: inconsistency in the data types used in read and write

2017-11-20 Thread GitBox
zhaijack opened a new issue #750: inconsistency in the data types used in read and write URL: https://github.com/apache/bookkeeper/issues/750 **FEATURE REQUEST** 1. Please describe the feature you are requesting. there is an inconsistency in the data types used in read and

[GitHub] jiazhai commented on issue #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-20 Thread GitBox
jiazhai commented on issue #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#issuecomment-345913937 updated this PR to keep old behavior of LedgerEntry; the tests that use client.LedgerEntry was un -touched.

[GitHub] sijie closed pull request #237: issue #236: shaded jar lose necessary bk jar to execute

2017-11-20 Thread GitBox
sijie closed pull request #237: issue #236: shaded jar lose necessary bk jar to execute URL: https://github.com/apache/distributedlog/pull/237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie closed issue #236: shaded jar lose necessary bk jar to execute

2017-11-20 Thread GitBox
sijie closed issue #236: shaded jar lose necessary bk jar to execute URL: https://github.com/apache/distributedlog/issues/236 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #749: Update release date for 4.5.1

2017-11-20 Thread GitBox
sijie commented on issue #749: Update release date for 4.5.1 URL: https://github.com/apache/bookkeeper/issues/749#issuecomment-345912462 @eolivelli you need to update the release date for 4.5.1 after it is announced. This is

[GitHub] sijie opened a new issue #749: Update release date for 4.5.1

2017-11-20 Thread GitBox
sijie opened a new issue #749: Update release date for 4.5.1 URL: https://github.com/apache/bookkeeper/issues/749 we need to update the release date for `4.5.1` in `releases.md` when 4.5.1 is announced. This is an

[GitHub] sijie closed pull request #748: Issue 747: Reorder releases menu - 4.5.1 should appear before 4.5.0

2017-11-20 Thread GitBox
sijie closed pull request #748: Issue 747: Reorder releases menu - 4.5.1 should appear before 4.5.0 URL: https://github.com/apache/bookkeeper/pull/748 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed issue #747: Reorder releases menu, 4.5.0 must be after 4.5.1

2017-11-20 Thread GitBox
sijie closed issue #747: Reorder releases menu, 4.5.0 must be after 4.5.1 URL: https://github.com/apache/bookkeeper/issues/747 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie opened a new pull request #748: Issue 747: Reorder releases menu - 4.5.1 should appear before 4.5.0

2017-11-20 Thread GitBox
sijie opened a new pull request #748: Issue 747: Reorder releases menu - 4.5.1 should appear before 4.5.0 URL: https://github.com/apache/bookkeeper/pull/748 Descriptions of the changes in this PR: - 4.5.1 should appear before 4.5.0 - bump dlog version to 0.5.0

[GitHub] eolivelli opened a new issue #747: Reorder releases menu, 4.5.1 must be after 4.5.0

2017-11-20 Thread GitBox
eolivelli opened a new issue #747: Reorder releases menu, 4.5.1 must be after 4.5.0 URL: https://github.com/apache/bookkeeper/issues/747 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #738: Issue 731: refine LedgerEntry interface and implementation

2017-11-20 Thread GitBox
sijie commented on issue #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#issuecomment-345783089 @ivankelly that is the 4.5 behavior of LedgerEntry. in the new api, we should change LedgerEntry to be a more consistent

Jenkins build is back to normal : bookkeeper-master #1949

2017-11-20 Thread Apache Jenkins Server
See

[GitHub] eolivelli closed pull request #746: Issue-732 Update Dockerfile for 4.5.1 version

2017-11-20 Thread GitBox
eolivelli closed pull request #746: Issue-732 Update Dockerfile for 4.5.1 version URL: https://github.com/apache/bookkeeper/pull/746 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jiazhai commented on a change in pull request #737: Issue 688: add bookkeeper-all package and update notice files

2017-11-20 Thread GitBox
jiazhai commented on a change in pull request #737: Issue 688: add bookkeeper-all package and update notice files URL: https://github.com/apache/bookkeeper/pull/737#discussion_r151976042 ## File path: bookkeeper-dist/src/assemble/bin-all.xml ## @@ -0,0 +1,100 @@ +

[GitHub] sijie commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

2017-11-20 Thread GitBox
sijie commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#issuecomment-345653926 @jvrao @ivankelly @reddycharan please take a look when you have time.

[GitHub] jiazhai commented on issue #737: Issue 688: add bookkeeper-all package and update notice files

2017-11-20 Thread GitBox
jiazhai commented on issue #737: Issue 688: add bookkeeper-all package and update notice files URL: https://github.com/apache/bookkeeper/pull/737#issuecomment-345631830 +1 for the Integration test. This is an automated

Jenkins build is still unstable: distributedlog-release-nightly-snapshot #85

2017-11-20 Thread Apache Jenkins Server
See

[GitHub] asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

2017-11-20 Thread GitBox
asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-345621880 SUCCESS --none-- This

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #108

2017-11-20 Thread Apache Jenkins Server
See

[GitHub] eolivelli commented on a change in pull request #737: Issue 688: add bookkeeper-all package and update notice files

2017-11-20 Thread GitBox
eolivelli commented on a change in pull request #737: Issue 688: add bookkeeper-all package and update notice files URL: https://github.com/apache/bookkeeper/pull/737#discussion_r151921043 ## File path: bookkeeper-server/bin/bookkeeper ## @@ -71,13 +71,18 @@ else fi