[GitHub] ivankelly commented on a change in pull request #771: Don't require password to create or open ledgers

ivankelly commented on a change in pull request #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#discussion_r152872587 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-346698474 Also, tests probably fail with this, I didn't run them before pushing. Will do so tomorrow.

[GitHub] sijie commented on issue #774: Open should run recovery by default

sijie commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-346684200 yes we intentionally made no recovery as default. because that is what people would typically expect for a "single-writer, multiple-readers"

[GitHub] eolivelli commented on issue #771: Don't require password to create or open ledgers

eolivelli commented on issue #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#issuecomment-346683957 This is what I did initially, but @sijie required it. I prefer to have a default empty password.

[GitHub] eolivelli commented on issue #774: Open should run recovery by default

eolivelli commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-346683530 Initially I did do, but @sijie wanted this way. For me are ok both modes This

[GitHub] ivankelly opened a new pull request #774: Open should run recovery by default

ivankelly opened a new pull request #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774 This is how it has always been and is the safer option. Non-recovery open is for tailing, which isn't the primary usecase for open. The primary usecase is

[GitHub] ivankelly opened a new pull request #773: Shade bookkeeper-common into bookkeeper-server

ivankelly opened a new pull request #773: Shade bookkeeper-common into bookkeeper-server URL: https://github.com/apache/bookkeeper/pull/773 bookkeeper-server extends some interfaces from bookkeeper-common which in turn use guava. As guava is shaded and relocated, we need to shade the

[GitHub] ivankelly opened a new pull request #772: bookkeeper script excludes sources jar

ivankelly opened a new pull request #772: bookkeeper script excludes sources jar URL: https://github.com/apache/bookkeeper/pull/772 bin/bookkeeper tries to figure out the location of the bookkeeper-server jar, so that a locally built jar can be run in place. However, this has been

[GitHub] ivankelly opened a new pull request #771: Don't require password to create or open ledgers

ivankelly opened a new pull request #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771 The new fluent api shouldn't require a password to create or open a ledger. The password is only an extra check to avoid accidentally

[GitHub] eolivelli commented on a change in pull request #770: Make LedgerEntries an Iterable

eolivelli commented on a change in pull request #770: Make LedgerEntries an Iterable URL: https://github.com/apache/bookkeeper/pull/770#discussion_r152845233 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java ## @@ -20,27

[GitHub] ivankelly opened a new pull request #770: Make LedgerEntries an Iterable

ivankelly opened a new pull request #770: Make LedgerEntries an Iterable URL: https://github.com/apache/bookkeeper/pull/770 This seems to have been overlooked in the previous changes. As the title says, this change just adds the Iterable to the interfaces from which LedgerEntries

[GitHub] eolivelli commented on issue #742: Issue-744 BP-18 introduce write flags

eolivelli commented on issue #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#issuecomment-346642148 @sijie I will add docs as soon as we merge #764 This is an automated message

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152822846 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346614792 the first issue, looks like a bug of github? seems all the state in

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346614792 the first issue, looks like a bug of github? seems all the state in

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346609009 not sure what is the error, according the the example pr_reviews, reviewers_ids should be added, ``` [

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346605849 this part of code not get the right list, ``` approval_review_states = ['approved'] pr_reviews =

[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346605849 seems related with github api changes? this part of code not get the right list, ```

[GitHub] jiazhai opened a new issue #769: defect of merge script: some times not able to get reviewers list

jiazhai opened a new issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? merge PR #727. - What did you

[GitHub] jiazhai closed pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai closed pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jiazhai closed issue #693: Define a LedgerEntries interface for read entries

jiazhai closed issue #693: Define a LedgerEntries interface for read entries URL: https://github.com/apache/bookkeeper/issues/693 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346598103 seems, it is not able to merge with merge script, it reported: ``` bookkeeper git:(master) ? python

[GitHub] jiazhai commented on issue #751: create assertEventuallyEquals for unit test, and do the clean up

jiazhai commented on issue #751: create assertEventuallyEquals for unit test, and do the clean up URL: https://github.com/apache/bookkeeper/issues/751#issuecomment-346571683 @eolivelli, That is great. This is an automated

[GitHub] ivankelly closed issue #763: Javadoc layout should be reflected to new modules

ivankelly closed issue #763: Javadoc layout should be reflected to new modules URL: https://github.com/apache/bookkeeper/issues/763 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] ivankelly closed pull request #768: Issue 763: Javadoc layout should reflect new modules

ivankelly closed pull request #768: Issue 763: Javadoc layout should reflect new modules URL: https://github.com/apache/bookkeeper/pull/768 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152748012 ## File path:

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152748028 ## File path:

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152740174 ## File path:

[GitHub] ivankelly commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

ivankelly commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r152743167 ## File path:

[GitHub] jiazhai closed pull request #754: Issue #753: Allow option to disable data sync on journal

jiazhai closed pull request #754: Issue #753: Allow option to disable data sync on journal URL: https://github.com/apache/bookkeeper/pull/754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jiazhai closed issue #753: Allow option to disable data sync on journal

jiazhai closed issue #753: Allow option to disable data sync on journal URL: https://github.com/apache/bookkeeper/issues/753 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152740174 ## File path:

[GitHub] eolivelli commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

eolivelli commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152738635 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152738153 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152738102 ## File path:

[GitHub] jiazhai closed pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

jiazhai closed pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] jiazhai closed issue #750: inconsistency in the data types used in read and write

jiazhai closed issue #750: inconsistency in the data types used in read and write URL: https://github.com/apache/bookkeeper/issues/750 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ivankelly commented on issue #552: Update BookKeeper Tutorial to the new API

ivankelly commented on issue #552: Update BookKeeper Tutorial to the new API URL: https://github.com/apache/bookkeeper/issues/552#issuecomment-346551463 @sijie I had started on it, but had to wait for api stuff to be finalized before proceeding. Will send a PR today. -Ivan

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #111

See

Build failed in Jenkins: distributedlog-release-nightly-snapshot #88

See -- [...truncated 296.71 KB...] [INFO] Downloaded: